Skip to content

fix(eest): make the fill report self-contained so it renders from S3 #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skylenet merged 1 commit into from
Jul 9, 2026
Merged

fix(eest): make the fill report self-contained so it renders from S3 #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/builder/eest_payloads.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,14 @@ func (b *EESTPayloadsBuilder) runFill(
// passed/failed tally for the build summary (the json-report plugin ships
// in the fill image). fill-stateful continues through failures, so a
// partial fill still records how many tests failed.
"PYTEST_ADDOPTS": "-o cache_dir=/tmp/.pytest_cache --json-report --json-report-file=" + fillOutputPath + "/" + pytestReportFile,
//
// --self-contained-html inlines the pytest-html report's CSS into
// .meta/report_fill.html so it has no relative assets/ references. That
// lets the UI serve it from a presigned S3 URL (or an iframe) with full
// styling — a linked assets/style.css would resolve to an unsigned S3
// URL and 403. EEST only sets htmlpath, not self_contained_html, so this
// flag is honored.
"PYTEST_ADDOPTS": "-o cache_dir=/tmp/.pytest_cache --self-contained-html --json-report --json-report-file=" + fillOutputPath + "/" + pytestReportFile,
// fill-stateful reads its commit hash from the /eest git checkout; as a
// non-root user git can refuse with "dubious ownership". Inject
// safe.directory=* via git's env-based config so it trusts the repo.
Expand Down
Loading