fix(models): OR-group libp2p gossip dep; publish release/** images#297
Open
samcm wants to merge 3 commits into
Open
fix(models): OR-group libp2p gossip dep; publish release/** images#297samcm wants to merge 3 commits into
samcm wants to merge 3 commits into
Conversation
libp2p_gossipsub_beacon_block is published by a pipeline deployed independently of the beacon API sentries. When it stops (e.g. a sidecar predating a fork's gossip changes, as happened on glamsterdam-devnet-7 at gloas activation), fct_block_first_seen_by_node and fct_block_proposer_head stall forever because it is a hard dependency. OR-group it with beacon_api_eth_v1_events_block so the fresher source gates forwardfill.
Per-devnet release branches (release/glamsterdam-devnet-7) carry models for raw tables that only exist on those devnets, so they cannot ship to mainnet via master. Publishing branch-ref tags (release-glamsterdam-devnet-7) lets devnet deployments pin them, mirroring xatu's release branch convention.
The OR-group lets forwardfill run at the fresher source's pace, so rows from the slower source can land after their slot's interval was already processed. Widen every data scan 90s behind the interval start so subsequent tasks recompute the trailing slots with the fuller data; ReplacingMergeTree(updated_date_time) keeps the newest version. The window must widen every source uniformly - recomputing a slot from a subset of sources would replace a complete row with a worse one. The duty-completeness gate in fct_block_proposer_head keeps the exact interval: its 12s-grid arithmetic assumes the scan window equals the interval, and trailing slots were gated by their own task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
libp2p_gossipsub_beacon_blockinto an OR-group withbeacon_api_eth_v1_events_blockinfct_block_first_seen_by_nodeandfct_block_proposer_head, so a stopped libp2p feed no longer stalls forwardfill. Both models froze on glamsterdam-devnet-7 when the gossip pipeline stopped publishing at gloas activation, while the beacon API sentries kept flowing.Also adds
release/**to the docker publish workflow branches. Per-devnet release branches (release/glamsterdam-devnet-7) get persistent image tags likerelease-glamsterdam-devnet-7, mirroring xatu's convention — the branch carrying the gloas ePBS models can then be pinned by devnet deployments without shipping those models to mainnet.