Skip to content

Migrate hardhat tests to Forge#171

Open
syntrust wants to merge 30 commits intomainfrom
forge-test
Open

Migrate hardhat tests to Forge#171
syntrust wants to merge 30 commits intomainfrom
forge-test

Conversation

@syntrust
Copy link
Copy Markdown
Contributor

@syntrust syntrust commented Oct 10, 2025

Addressing #152, this PR translated Hardhat tests into Solidity using Foundry.

Additionally, some cleanups were done, and the test files were separated from the source code. No Solidity source code change.

UT workflow passed.

Note that the environment variable RPC_URL_L1 needs to be set locally (or as a repository secret in GitHub Action) to enable some of the tests, like testCompleteMiningProcess.

@syntrust syntrust marked this pull request as draft October 10, 2025 09:52
@syntrust syntrust changed the title translate tests Migrate hardhat tests to Forge Oct 14, 2025
@syntrust syntrust marked this pull request as ready for review October 14, 2025 09:57
@syntrust syntrust changed the base branch from lint-gas to main October 14, 2025 10:02
@qzhodl
Copy link
Copy Markdown
Contributor

qzhodl commented Jan 21, 2026

Since we’ve already deployed the mainnet code, a safer approach might be to split this PR into two smaller ones:

  • Forge migration only: Convert the project into a pure Forge setup and update/migrate all tests accordingly. (No functional Solidity changes.)
  • Solidity warnings cleanup: Address the Solidity compiler/linter warnings in a follow-up PR, once the Forge migration is merged and stable.

@syntrust
Copy link
Copy Markdown
Contributor Author

Since we’ve already deployed the mainnet code, a safer approach might be to split this PR into two smaller ones:

  • Forge migration only: Convert the project into a pure Forge setup and update/migrate all tests accordingly. (No functional Solidity changes.)
  • Solidity warnings cleanup: Address the Solidity compiler/linter warnings in a follow-up PR, once the Forge migration is merged and stable.

The Solidity code in this PR is all test code; there is no Solidity warnings cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants