Open
Conversation
Contributor
|
Since we’ve already deployed the mainnet code, a safer approach might be to split this PR into two smaller ones:
|
Contributor
Author
The Solidity code in this PR is all test code; there is no Solidity warnings cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #152, this PR translated Hardhat tests into Solidity using Foundry.
Additionally, some cleanups were done, and the test files were separated from the source code. No Solidity source code change.
UT workflow passed.
Note that the environment variable
RPC_URL_L1needs to be set locally (or as a repository secret in GitHub Action) to enable some of the tests, liketestCompleteMiningProcess.