Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compile time #28

Merged
merged 3 commits into from
May 10, 2024
Merged

Improve compile time #28

merged 3 commits into from
May 10, 2024

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented May 3, 2024 •
edited
Loading

Only build unit tests if LPP_BUILD_TESTS=1 and updated README.md. This speeds up compilation with catkin build by ~10X.

@4c3y 4c3y added the enhancement New feature or request label May 3, 2024
@4c3y 4c3y marked this pull request as ready for review May 3, 2024 14:06
@4c3y 4c3y requested review from michaelpantic and mikeallenspach and removed request for michaelpantic May 3, 2024 14:06
clanegge
clanegge approved these changes May 10, 2024
View reviewed changes
Copy link

@clanegge clanegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also the updated readme is useful:)

@4c3y 4c3y merged commit ef406d0 into master May 10, 2024
13 checks passed
@4c3y 4c3y deleted the feature/improve_compile_time branch May 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clanegge clanegge clanegge approved these changes

@mikeallenspach mikeallenspach Awaiting requested review from mikeallenspach

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4c3y @clanegge