Skip to content

Fix analysis apply#103

Merged
transientlunatic merged 1 commit intov0.7-previewfrom
fix-event-apply
Feb 25, 2026
Merged

Fix analysis apply#103
transientlunatic merged 1 commit intov0.7-previewfrom
fix-event-apply

Conversation

@transientlunatic
Copy link
Collaborator

Description

This MR fixes a bug with the application of analysis blueprints.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test coverage improvement

Motivation and Context

This MR fixes an issue with the application of analysis blueprints.

Fixes #(issue number) (if applicable)

Changes Made

List the main changes:

Testing

How has this been tested?

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested with pipeline: (LALInference / Bilby / BayesWave / RIFT / N/A)

Test configuration:

  • Python version(s):
  • Operating System:
  • Cluster environment (if applicable):

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Documentation

  • Documentation updated (if applicable)
  • Changelog entry added
  • README updated (if applicable)

Breaking Changes

Does this PR introduce any breaking changes? If yes, describe:

Additional Notes

Any additional information, concerns, or considerations for reviewers.

Screenshots (if applicable)

For UI or output changes, include before/after screenshots or terminal output.


Reviewer Notes:

  • Does this PR need review from specific domain experts?
  • Any particular areas that need careful review?

Copilot AI review requested due to automatic review settings February 6, 2026 11:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a variable shadowing bug in the apply_page function where a local variable named event was shadowing the function parameter with the same name. The function parameter event is used to specify which event to apply blueprints to, while the local variable stores an Event object instance. This shadowing could cause bugs when processing event blueprints.

Changes:

  • Renamed local variable event to event_obj throughout the "event" kind handler section to avoid shadowing the event function parameter
  • Updated all 15 references to use the new event_obj variable name consistently

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@transientlunatic transientlunatic merged commit 526fc15 into v0.7-preview Feb 25, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants