fix: isolate recipe runner Python dependency - #347
Open
erikoliver wants to merge 1 commit into
Open
erikoliver wants to merge 1 commit into
erikoliver wants to merge 1 commit into
Conversation
erikoliver
marked this pull request as ready for review
August 14, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
run-recipe.shcurrently falls back topython -m pip install pyyaml. Modern Homebrew and system Python installations may reject that write because the interpreter is externally managed under PEP 668, preventing the recipe runner from starting.Behavior
When PyYAML is already importable, behavior is unchanged. Otherwise, the wrapper creates or reuses an interpreter-specific environment under:
$XDG_CACHE_HOME/spark-vllm-docker/run-recipe-venv-py<major>.<minor>When
XDG_CACHE_HOMEis unset, it uses$HOME/.cache. Before reuse, the wrapper verifies that the environment was created from the currently selected Python executable. A stale, broken, or mismatched environment is recreated withvenv --clear.Testing
bash -n run-recipe.shgit diff --check origin/main...HEAD./run-recipe.sh --list./run-recipe.sh --listorigin/main