Profilequestion: Change question field to rich text #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
approved these changes
Feb 17, 2025
| @@ -38,14 +39,14 @@ class IProfileQuestion(model.Schema, IRichDescription, IBasic): | |||
| be skipped, or repeated multiple times. | |||
| """ | |||
|
|
|||
| question = schema.TextLine( | |||
| question = HtmlText( | |||
There was a problem hiding this comment.
👀 I'd have used plone.app.textfield.RichText instead and use Plone's portal_transform machinery with maybe a custom transform and also benefit from transform caching, etc.
But this is the way we do it in euphorie and we don't change that for this PR, alright.
There was a problem hiding this comment.
Yeah, I just want to be consistent for the moment. But maybe we can talk about switching if you see benefits there...
| <dl class="grid span-13"> | ||
| <dt i18n:translate="label_profilequestion_question">Question</dt> | ||
| <dd>${context/question}</dd> |
There was a problem hiding this comment.
We could also do something like:
<dd tal:replace="structure python:view.get_safe_html(context.question)"></dd>
There was a problem hiding this comment.
We sure could, but it would end up with very little horizontal space, so I pulled it out of the dl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref syslabcom/scrum#2859