Add text navigation mode #437
Open
+70
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement text navigation mode to enable usage of arrow keys in text fields as well as using them to focus previous/ next field.
pommfresser
force-pushed
the
feat/elicitation-add-text-navigation-mode
branch
from
f8675c0 to
d31b4ff
Compare
|
Definitely a fan of the mode, agree with the Toolbar; I do wonder how discoverable this is for the average user? I guess looking at it, only submits on the buttons anyway. Wonder if @chughtapan has thoughts as they worked on this too. |
|
Definitely seems like a good idea to me if we keep the current navigation mode as the default and add the text mode as an optional feature. The point about discovery is valid, and I'm not sure how best to address that, but the feature itself is worthwhile imo. |
chughtapan
reviewed
Oct 21, 2025
| self.multiline_fields.add(field_name) | ||
| break | ||
|
|
||
| # Ctrl+J submits in text navigation mode (equivalent to enter in field navigation mode) |
There was a problem hiding this comment.
Maybe we can get rid of this completely now? Submit should only work in the text field navigation mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the navigation in text fields in elicitation forms is difficult, I implemented, similar to multiline mode, a text navigation mode for elicitation forms. With CTRL-T, it's possible to toggle between text navigation and field navigation mode. Field navigation mode represents the already implemented key bindings, text navigation modes allows you to use the arrow keys to navigate inside fields.
The toolbar is quite long now and hasn't a good indicator which mode is currently used. I am open for good ideas.
If you like the idea, you can merge this pull request, else I'm fine with closing it.