Ensure Secure File Permissions for Device Identity - #15
Open
kolega-dev-github-app[bot] wants to merge 1 commit into
Open
Ensure Secure File Permissions for Device Identity#15kolega-dev-github-app[bot] wants to merge 1 commit into
kolega-dev-github-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security vulnerability (CWE-732) related to insecure file permissions on the device identity file. It ensures the file is created and maintained with secure permissions (0600) to prevent sensitive cryptographic material from being accessed by unauthorized users.
Changes
setSecureFilePermissions()function to safely set file permissions, handling errors securelywriteSecureFile()to create the identity file with secure permissions from the start, using a restrictive umaskverifySecurePermissions()to check the file permissions and throw an error if they are insecureloadOrCreateDeviceIdentity()function to verify and enforce secure permissions on the identity fileTesting
The changes can be tested by creating a new device identity file and verifying the file permissions are 0600. Additionally, intentionally setting insecure permissions and ensuring the application fails securely.