-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Use dinosaur names for session display IDs #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
812d5bd
2ac37d0
139be5e
fb0f9a1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| """Human-readable session ID generation (Docker-style names).""" | ||
| """Human-readable session ID generation (dinosaur-themed names).""" | ||
|
|
||
| import random | ||
|
|
||
| # Word lists for human-readable session IDs | ||
| # ~50 adjectives x ~50 animals = ~2500 unique combinations | ||
| # ~50 adjectives x ~50 dinosaurs = ~2500 unique combinations | ||
| ADJECTIVES = [ | ||
| "brave", | ||
| "calm", | ||
|
|
@@ -57,60 +57,60 @@ | |
| "rustic", | ||
| ] | ||
|
|
||
| ANIMALS = [ | ||
| "badger", | ||
| "cat", | ||
| "dog", | ||
| "eagle", | ||
| "falcon", | ||
| "gopher", | ||
| "heron", | ||
| "ibis", | ||
| "jaguar", | ||
| "koala", | ||
| "lemur", | ||
| "moose", | ||
| "newt", | ||
| "otter", | ||
| "panda", | ||
| "quail", | ||
| "rabbit", | ||
| "salmon", | ||
| "tiger", | ||
| "urchin", | ||
| "viper", | ||
| "walrus", | ||
| "yak", | ||
| "zebra", | ||
| "bear", | ||
| "crane", | ||
| "duck", | ||
| "fox", | ||
| "goose", | ||
| "hawk", | ||
| "iguana", | ||
| "jay", | ||
| "alpaca", | ||
| "bison", | ||
| "coyote", | ||
| "dingo", | ||
| "ferret", | ||
| "gecko", | ||
| "hyena", | ||
| "impala", | ||
| "jackal", | ||
| "kiwi", | ||
| "llama", | ||
| "marmot", | ||
| "narwhal", | ||
| "osprey", | ||
| "parrot", | ||
| "raven", | ||
| "sloth", | ||
| "toucan", | ||
| DINOSAURS = [ | ||
| "trex", | ||
| "raptor", | ||
| "stego", | ||
| "bronto", | ||
| "tricera", | ||
| "ankylo", | ||
| "diplo", | ||
| "allo", | ||
| "ptero", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Important] The previous review flagged this and it remains unaddressed: many files still reference
Per CLAUDE.md: "When modifying API: Update CLI help, MCP docstrings, and guide.md together." At minimum, update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Important] This is the third review flagging this: documentation and source comments across the repo still reference Files that need updating (at minimum the non-test files):
Test files ( |
||
| "plesio", | ||
| "spino", | ||
| "carno", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] Some of these abbreviated names are pretty opaque — |
||
| "iguano", | ||
| "hadro", | ||
| "cerato", | ||
| "compsy", | ||
| "dilo", | ||
| "galli", | ||
| "thero", | ||
| "baryon", | ||
| "deinon", | ||
| "styra", | ||
| "pachy", | ||
| "corytho", | ||
| "parasaur", | ||
| "maia", | ||
| "oviraptor", | ||
| "draco", | ||
| "kentro", | ||
| "camara", | ||
| "titano", | ||
| "megalo", | ||
| "archeo", | ||
| "coelo", | ||
| "micro", | ||
| "proto", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] Some abbreviated dinosaur names are quite opaque — e.g., There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Suggestion] Repeated from prior reviews: some abbreviated names are quite opaque — |
||
| "sino", | ||
| "yuty", | ||
| "theri", | ||
| "tarbos", | ||
| "acrocanth", | ||
| "giganto", | ||
| "amarga", | ||
| "citipati", | ||
| "edmonto", | ||
| "lambeo", | ||
| "nodosaur", | ||
| "ourano", | ||
| "suchomi", | ||
| "utah", | ||
| ] | ||
|
|
||
|
|
||
| def generate_session_id() -> str: | ||
| """Generate a human-readable session ID like 'brave-tiger'.""" | ||
| return f"{random.choice(ADJECTIVES)}-{random.choice(ANIMALS)}" | ||
| """Generate a dinosaur-themed session ID like 'brave-trex'.""" | ||
| return f"{random.choice(ADJECTIVES)}-{random.choice(DINOSAURS)}" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Important]
guide.mdstill uses"brave-tiger"as the example display ID (lines 34 and 37), andCLAUDE.mdreferences"brave-tiger"(line 146) and calls this "Docker-style display_id generation" (line 83). These should be updated to reflect the new dinosaur theme (e.g.,"brave-trex") for consistency. Per CLAUDE.md: "When modifying API: Update CLI help, MCP docstrings, and guide.md together."