Skip to content

Implement mutable array interface for GeometryVector #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evetion merged 2 commits into from
Jan 8, 2026
Merged

Implement mutable array interface for GeometryVector #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a4c4f
Implement mutable array interface for GeometryVector
Jan 8, 2026
cd89653
Remove other methods.
evetion Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,7 @@ Base.setindex!(G::GeometryVector, v, i::Int) = setindex!(parent(G), v, i)

# https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-array
Base.similar(G::GeometryVector, ::Type{T}, dims::Dims) where {T} = GeometryVector(similar(parent(G), T, dims))

# Mutable array interface
# TODO Invalidate spatial index on mutations
Base.deleteat!(G::GeometryVector, i) = (deleteat!(parent(G), i); G)
22 changes: 22 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,28 @@ end
@test GI.geometrycolumns(t) == (:geom,)
end

@testitem "GeometryVector mutability" setup = [Setup] begin
using DataFrames

# Test deleteat! directly on GeometryVector
gv = GDF.GeometryVector(AG.createpoint.(coords))
@test length(gv) == 10
deleteat!(gv, 5)
@test length(gv) == 9

# Test with DataFrame filtering (the original issue scenario)
df = DataFrame(geometry=GDF.GeometryVector(AG.createpoint.(coords)), name="test")
@test nrow(df) == 10
filter!(row -> row.name == "test", df)
@test nrow(df) == 10

# Test with subset removal
df2 = DataFrame(geometry=GDF.GeometryVector(AG.createpoint.(coords)), value=1:10)
filter!(row -> row.value > 5, df2)
@test nrow(df2) == 5
@test length(df2.geometry) == 5
end

filter(ti) = !(:nowindows in ti.tags && Sys.iswindows())

@run_package_tests filter = filter
Loading