Fix PROV import #26
Merged
Fix PROV import #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simpler http://www.w3.org/ns/prov-o import (aka http://www.w3.org/ns/prov-o.ttl or http://www.w3.org/ns/prov-o.rdf after content negotation) is preferred to http://www.w3.org/ns/prov#. See also evoinfo#25.
hlapp
reviewed
May 4, 2017
ontology/miapa.owl
Outdated
| @@ -40,8 +40,8 @@ | |||
| This ontology is maintained at http://github.com/miapa/miapa, and requests for changes or additions should be filed at the issue tracker there. The discussion list is at [email protected]. Further resources about MIAPA can be found at the project's main page at http://evoio.org/wiki/MIAPA.</dc:description> | |||
| <dc:creator>Hilmar Lapp</dc:creator> | |||
| <owl:imports rdf:resource="&obo;cdao.owl"/> | |||
| <owl:versionIRI rdf:resource="&obo;miapa/2013-02-01/miapa.owl"/> | |||
| <owl:imports rdf:resource="http://www.w3.org/ns/prov#"/> | |||
| <owl:versionIRI rdf:resource="&obo;miapa/2017-TODO-TODO/miapa.owl"/> | |||
There was a problem hiding this comment.
I don't think we have to have owl:versionIRI, and if we should have it, then I'm thinking shouldn't this just be the unversioned IRI of the ontology, i.e., &obo/miapa/miapa.owl.
I.e., conceptually this change is going to "master", not to a version branch or tag (if one existed). We'd cut a new release off of "master" when ready to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simpler http://www.w3.org/ns/prov-o import (aka http://www.w3.org/ns/prov-o.ttl or http://www.w3.org/ns/prov-o.rdf after content negotation) is preferred to http://www.w3.org/ns/prov#. See also #25.
Note that I left the
owl:versionIRIasTODOas it would no longer be 2013-02-01 - however OBO redirects straight to master rather than a tag/commit - so accepting this PR would 'break' OBO.