Skip to content

refactor(esl-image): officially deprecate ESLImage#3742

Merged
ala-n merged 1 commit intomainfrom
chore/deprecate-image
Apr 15, 2026
Merged

refactor(esl-image): officially deprecate ESLImage#3742
ala-n merged 1 commit intomainfrom
chore/deprecate-image

Conversation

@ala-n
Copy link
Copy Markdown
Collaborator

@ala-n ala-n commented Apr 15, 2026

No description provided.

@ala-n ala-n added this to the ⚡ESL: 6.0.0 Major release milestone Apr 15, 2026
@ala-n ala-n requested review from a team April 15, 2026 01:47
@ala-n ala-n self-assigned this Apr 15, 2026
@ala-n ala-n requested review from NastaLeo, Copilot, dshovchko and yadamskaya and removed request for a team April 15, 2026 01:47
@ala-n ala-n added the needs review The PR is waiting for review label Apr 15, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates the legacy ESLImage custom element and removes it from the primary ESL “all” entrypoints, while keeping it available for the website demo app via explicit legacy imports.

Changes:

  • Mark ESLImage as deprecated in its JSDoc.
  • Remove esl-image exports/styles from packages/esl/src/all.ts and packages/esl/src/all.less.
  • Re-add legacy ESLImage exports/styles explicitly in packages/esl-website for demos.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/esl/src/esl-image/core/esl-image.ts Adds a deprecation notice to the ESLImage public API docs.
packages/esl/src/all.ts Stops re-exporting legacy esl-image from the main barrel entrypoint.
packages/esl/src/all.less Stops including legacy esl-image styles in the aggregated LESS bundle.
packages/esl-website/src/lib.ts Re-exports ESLImage via a deep import for website demos.
packages/esl-website/src/lib.less Re-imports legacy esl-image LESS for website demos.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/esl/src/all.ts
Comment thread packages/esl/src/all.less
@qltysh
Copy link
Copy Markdown

qltysh bot commented Apr 15, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@ala-n ala-n merged commit a667231 into main Apr 15, 2026
15 of 16 checks passed
@ala-n ala-n deleted the chore/deprecate-image branch April 15, 2026 16:40
@ci-github-action-bot ci-github-action-bot bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs review The PR is waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants