-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Four new exercises #123
Four new exercises #123
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
I've re-opened the PR. I'd forgotten about the "auto-close". Let's have a look at your work |
Are you writing these on a Windows, Linux or Mac? The reason I ask is that ordinarily one would not expect to see the files in the bin folder appearing as part of the PR and that suggests that CRLF line ends are being encountered |
For binary-search was the any particular reason why you chose to work out a binary search rather than use the |
In protein-translation and likely in others, it would be better use |
|
Please do not use GOBACK. It confuses COBOLCHECK, the unit test tool. |
Also configlet is complaining. You should check your submissions with configlet before creating a PR. In this case configlet says,
|
So @kapitaali , how about you delete this PR, fix things up and submit each exercise as a separate PR. |
Closed, doing it 1by1 |
It says in the blurb, "Implement a binary search algorithm". If it's not explicit enough that one should implement it oneself, I can add it to the instructions. |
Linux, Pop_OS is Ubuntu |
Hi,
please find four new COBOL track exercises: binary-search, protein-translation, secret-handshake, space-age
Let's hope I have all the needed information added in config files.