-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a "Test-Driven Development" document #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 😄
Thank you for creating this - it is going to really help a lot of students and mentors.
This is really great :) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approving, but with one potential suggestion.
I wonder if we should mention not submitting the test files, as once that happens, they no longer (as far as I remember) get updated when updates happen, and become the responsibility of the student to ensure that they are in a state that works for them. At least a warning to not submit modified the test files. I have helped several students over the years that have unknowningly submitted them (usually through globbing extensions when submitting, rather than purposefully and carefully) while some know better and do so with purpose. |
This is not the place for it. I don't think I even mention the CLI at all. Here would be better: https://exercism.org/docs/using/solving-exercises/working-locally#h-submitting-your-solution |
Couple more comments:
|
What would you say about it? It may be more complicated than just "first comment-out all the tests and uncomment them one-by-one". I don't want to have to address the technicalities of several tracks.
Again, what would you say about it? I don't think we need to mandate anything, and I think this document suggests it's a good idea but does not preclude any other way. We have some exercises where "write just enough to pass the first test" is actually solving the whole exercise (I'm looking at you zebra puzzle). |
That should be enough. No need to say anything about individual tracks.
Nothing at this point. I believe the recent changes should suffice :) |
Co-authored-by: Jeremy Walker <[email protected]> Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Victor Goff <[email protected]>
Co-authored-by: Isaac Good <[email protected]> Co-authored-by: Anastasios Chatzialexiou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with final suggestions
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
@BethanyG @iHiD @kotp @tasxatzial @ErikSchierboom @IsaacG |
Forum thread http://forum.exercism.org/t/missing-tdd-document/14781