Skip to content

Conversation

@FraSanga
Copy link

As described in issue #340, I modified the file by attempting to perform the check with the AST.

I am uncertain if this is correct, but the tests I added also work with the examples I created.

As soon as I get the go-ahead, I'll also make a PR on website-copy.
I hope this has been helpful. 😄

@jiegillet
Copy link
Contributor

jiegillet commented Sep 27, 2025

Thank you for the PR!
Before I go into a detailed review, could I ask you to address two things:

  1. I don't understand why all the files you are modifying are completely redefined. As far as I could tell, you are only modifying a few lines, not the whole files. Could you figure it out and fix it? It would really help with the review and the git history.
  2. The tests in test_data are used as smoke tests for the CI, we don't typically add new ones in there unless we have a good reason. The tests you added in test/elixir_analyzer/test_suite/captains_log_test.exs should be enough.

@jiegillet jiegillet self-assigned this Sep 27, 2025
@FraSanga
Copy link
Author

It should be fixed now.
Every time Windows messes up the formatting at the end of the line.

@FraSanga FraSanga marked this pull request as ready for review September 27, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants