Skip to content

Allow building Docker image via script #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fapdash
Copy link
Contributor

@fapdash fapdash commented Mar 14, 2025

  • callers can pass in the optional variable docker_build_script
  • script should produce a Docker image
  • if the script variable is set the default Docker image build step isn't executed

See exercism/java-test-runner#147 for context


Would be nice to have caching, not sure how hard it is to add.

- callers can pass in the optional variable `docker_build_script`
- script should produce a Docker image
- if the script variable is set the default Docker image build step
  isn't executed

See exercism/java-test-runner#147 for context
@fapdash
Copy link
Contributor Author

fapdash commented Mar 14, 2025

Is there a recommended way to test this?

@ErikSchierboom
Copy link
Member

I have to think this through a bit, and that takes a bit more time with me no longer being employed at Exercism. There are a couple of things that spring to mind:

  • Caching (as you mentioned)
  • Security (execution of a script, probably fine due to test runner PRs requiring approval)
  • Ensure that when the script executes successfully, that a Docker image has actually been built
  • Ensure that when the script executes successfully, the Docker image has the right name
  • Returning a correct error code

So I think we'd at least need to have a wrapper script to handle all this. That is, if @iHiD feels like this is worth the effort (and he's very busy right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants