Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Moo to built-in class #685

Merged
merged 8 commits into from
Sep 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Perltidy addition
m-dango committed Sep 10, 2024
commit ab8f9c5bc88e6d21cc5557437abecd90559ca522
1 change: 1 addition & 0 deletions .perltidyrc
Original file line number Diff line number Diff line change
@@ -5,3 +5,4 @@
--novalign-side-comments
--freeze-newlines
--keep-old-breakpoints-after='('
--nowant-right-space='A'
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ use Feature::Compat::Class;

class BinarySearchTree;

field $root : param;
field $root :param;

method add ($data) {
$root->set($data);
@@ -31,9 +31,9 @@ method sort () {
}

class BinarySearchTree::Node {
field $data : reader : param;
field $left : reader;
field $right : reader;
field $data :reader :param;
field $left :reader;
field $right :reader;

method set ($new_data) {
if ( $new_data > $data ) {
8 changes: 4 additions & 4 deletions exercises/practice/binary-search-tree/lib/BinarySearchTree.pm
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ use experimental qw<class>;

class BinarySearchTree;

field $root : param;
field $root :param;

method add () {

@@ -15,9 +15,9 @@ method sort () {
}

class BinarySearchTree::Node {
field $data : reader : param;
field $left : reader;
field $right : reader;
field $data :reader :param;
field $left :reader;
field $right :reader;
}

1;
4 changes: 2 additions & 2 deletions exercises/practice/clock/.meta/solutions/lib/Clock.pm
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ class Clock;

use POSIX qw<floor>;

field $hour : reader : param = 0;
field $minute : reader : param = 0;
field $hour :reader :param = 0;
field $minute :reader :param = 0;

method time () {
return sprintf '%02d:%02d', $hour, $minute;
4 changes: 2 additions & 2 deletions exercises/practice/clock/lib/Clock.pm
Original file line number Diff line number Diff line change
@@ -3,8 +3,8 @@ use experimental qw<class>;

class Clock;

field $hour : reader : param;
field $minute : reader : param;
field $hour :reader :param;
field $minute :reader :param;

method time () {
return undef;
Original file line number Diff line number Diff line change
@@ -5,8 +5,8 @@ use Feature::Compat::Class;

class CustomSet;

field $elements : param = [];
field $set : reader(elements) = {};
field $elements :param = [];
field $set :reader(elements) = {};

ADJUST {
$set = { map { $_ => 1 } $elements->@* }
2 changes: 1 addition & 1 deletion exercises/practice/custom-set/lib/CustomSet.pm
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ use experimental qw<class>;

class CustomSet;

field $elements : reader : param;
field $elements :reader :param;

method is_empty () {
return undef;
4 changes: 2 additions & 2 deletions exercises/practice/queen-attack/.meta/solutions/lib/Queen.pm
Original file line number Diff line number Diff line change
@@ -5,8 +5,8 @@ use Feature::Compat::Class;

class Queen;

field $row : reader : param;
field $column : reader : param;
field $row :reader :param;
field $column :reader :param;

ADJUST {
die 'row not on board' if $row < 0 || $row > 7;
4 changes: 2 additions & 2 deletions exercises/practice/queen-attack/lib/Queen.pm
Original file line number Diff line number Diff line change
@@ -3,8 +3,8 @@ use experimental qw<class>;

class Queen;

field $row : reader : param;
field $column : reader : param;
field $row :reader :param;
field $column :reader :param;

method can_attack ($other) {
return undef;
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ use Feature::Compat::Class;

class RobotName;

field $name : reader;
field $name :reader;

ADJUST {
$name = $self->reset_name();
2 changes: 1 addition & 1 deletion exercises/practice/robot-name/lib/RobotName.pm
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ use experimental qw<class>;

class RobotName;

field $name : reader;
field $name :reader;

method reset_name () {
return undef;
Original file line number Diff line number Diff line change
@@ -5,9 +5,9 @@ use Feature::Compat::Class;

class Robot;

field $x : reader param;
field $y : reader param;
field $direction : reader param;
field $x :reader :param;
field $y :reader :param;
field $direction :reader :param;

method enact ($instructions) {
for my $step ( split //, $instructions ) {
12 changes: 6 additions & 6 deletions exercises/practice/robot-simulator/.meta/template-data.yaml
Original file line number Diff line number Diff line change
@@ -14,9 +14,9 @@ properties:
END

example: |-
field $x :reader param;
field $y :reader param;
field $direction :reader param;
field $x :reader :param;
field $y :reader :param;
field $direction :reader :param;

method enact ($instructions) {
for my $step (split //, $instructions) {
@@ -68,9 +68,9 @@ example: |-
}

stub: |-
field $x :reader param;
field $y :reader param;
field $direction :reader param;
field $x :reader :param;
field $y :reader :param;
field $direction :reader :param;

method enact ($instructions) {
return $self;
6 changes: 3 additions & 3 deletions exercises/practice/robot-simulator/lib/Robot.pm
Original file line number Diff line number Diff line change
@@ -3,9 +3,9 @@ use experimental qw<class>;

class Robot;

field $x : reader param;
field $y : reader param;
field $direction : reader param;
field $x :reader :param;
field $y :reader :param;
field $direction :reader :param;

method enact ($instructions) {
return $self;
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ use Feature::Compat::Class;

class SimpleCipher;

field $key : reader : param = join '', map { ( 'a' .. 'z' )[ rand 26 ] } 1 .. 100;
field $key :reader :param = join '', map { ( 'a' .. 'z' )[ rand 26 ] } 1 .. 100;

method encode ($plaintext) {
my $key_length = length $key;
2 changes: 1 addition & 1 deletion exercises/practice/simple-cipher/lib/SimpleCipher.pm
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ use experimental qw<class>;

class SimpleCipher;

field $key : reader : param = '';
field $key :reader :param = '';

method encode ($plaintext) {
return undef;