610 all pharo tests pass even though i didnt solve the exercise #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bajger
commented
Feb 22, 2024
Bajger
commented
- fixes All pharo tests pass even though i didn't solve the exercise #610
Bajger
added
x:action/fix
|
@glennj Thanks for review, @ErikSchierboom Thanks for approve. |
Bajger
commented
Feb 22, 2024
There was a problem hiding this comment.
As per discussion on Pharo Discord. Solution recommended by one of founders: https://discord.com/channels/223421264751099906/278558427796602882/1209857931022049280
ErikSchierboom
approved these changes
Feb 22, 2024
Bajger
deleted the
610-All-pharo-tests-pass-even-though-i-didnt-solve-the-exercise
branch
|
I don't think my review would have added any value. Kudos for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.