Skip to content

Chess Game: Rename nick_name method to nickname for consistency - #1769

Merged
kotp merged 5 commits into
exercism:mainfrom
lemonade-37:fix-nickname-method
Sep 4, 2025
Merged

Chess Game: Rename nick_name method to nickname for consistency#1769
kotp merged 5 commits into
exercism:mainfrom
lemonade-37:fix-nickname-method

Conversation

@lemonade-37

@lemonade-37 lemonade-37 commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

The problem description uses nickname, but the exercise code defined nick_name.
This update renames the method to nickname for consistency between the description and the code.
Please review.

Exercism Community Topics(Rename nick_name method to nickname for consistency)

@github-actions

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions Bot closed this Aug 29, 2025
@exercism exercism deleted a comment from github-actions Bot Aug 31, 2025
@kotp

kotp commented Aug 31, 2025

Copy link
Copy Markdown
Member

Please link to the discussion on the forum as well.

@kotp kotp reopened this Aug 31, 2025
@kotp kotp changed the title Rename nick_name method to nickname for consistency Chess Game: Rename nick_name method to nickname for consistency Aug 31, 2025
@kotp
kotp self-requested a review August 31, 2025 08:58
@lemonade-37

Copy link
Copy Markdown
Contributor Author

Please link to the discussion on the forum as well.

I've added the URL for Topics.

@kotp

kotp commented Sep 1, 2025

Copy link
Copy Markdown
Member

I have updated the discussion, waiting on some feedback on direction here. Trying hard to avoid breaking everyone's longtime passing tests for this exercise, if possible, while still doing the right thing.

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not positive this is all of the files that need to be examined, look in .meta as well.

@kotp

kotp commented Sep 3, 2025

Copy link
Copy Markdown
Member

Looks like discussion in the forum has converged on making all references in code and prose "nickname"! 💪🏾

@lemonade-37

Copy link
Copy Markdown
Contributor Author

I have committed a change that renames nick_name to nickname.
Please review.

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the discussion and the work done!

@kotp
kotp merged commit b42bdfd into exercism:main Sep 4, 2025
5 checks passed
@lemonade-37
lemonade-37 deleted the fix-nickname-method branch September 4, 2025 08:36
@kotp kotp mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants