Chess Game: Rename nick_name method to nickname for consistency - #1769
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Please link to the discussion on the forum as well. |
This reverts commit e2e51a0.
I've added the URL for Topics. |
|
I have updated the discussion, waiting on some feedback on direction here. Trying hard to avoid breaking everyone's longtime passing tests for this exercise, if possible, while still doing the right thing. |
kotp
left a comment
There was a problem hiding this comment.
I am not positive this is all of the files that need to be examined, look in .meta as well.
|
Looks like discussion in the forum has converged on making all references in code and prose "nickname"! 💪🏾 |
This reverts commit b98ff84.
|
I have committed a change that renames |
kotp
left a comment
There was a problem hiding this comment.
Thank you for the discussion and the work done!
The problem description uses
nickname, but the exercise code definednick_name.This update renames the method to
nicknamefor consistency between the description and the code.Please review.
Exercism Community Topics(Rename nick_name method to nickname for consistency)