fix: Exchange numerator and denominator (#182)

The first argument to Rational.new is numerator.
The second argument is denominator.

resolves #181

exercises/practice/rational-numbers/.meta/config.json

@@ -1,5 +1,6 @@
 {
   "authors": ["m-charlton"],
+  "contributors": ["keiravillekode"],
   "files": {
     "solution": ["rational-numbers.v"],
     "test": ["run_test.v"],

exercises/practice/rational-numbers/.meta/example.v

@@ -3,45 +3,45 @@ module main
 import math { gcd, pow, powi, signi }
 
 struct Rational {
-	denominator i64
 	numerator   i64
+	denominator i64
 }
 
 // a/b -> b/a
 fn (r Rational) invert() Rational {
-	return Rational.new(r.numerator, r.denominator)
+	return Rational.new(r.denominator, r.numerator)
 }
 
 //  a/b -> -a/b
 // -a/b ->  a/b
 fn (r Rational) negate() Rational {
-	return Rational.new(-1 * r.denominator, r.numerator)
+	return Rational.new(-1 * r.numerator, r.denominator)
 }
 
 // build a new Rational number
-pub fn Rational.new(denominator i64, numerator i64) Rational {
-	assert numerator != 0
+pub fn Rational.new(numerator i64, denominator i64) Rational {
+	assert denominator != 0
 
-	cmn_div := gcd(denominator, numerator)
+	cmn_div := gcd(numerator, denominator)
 
-	sign := if signi(denominator) == -1 || signi(numerator) == -1 {
+	sign := if signi(numerator) == -1 || signi(denominator) == -1 {
 		-1
 	} else {
 		1
 	}
 
-	return Rational{sign * math.abs(denominator) / cmn_div, math.abs(numerator) / cmn_div}
+	return Rational{sign * math.abs(numerator) / cmn_div, math.abs(denominator) / cmn_div}
 }
 
 //  a/b -> a/b
 // -a/b -> a/b
 pub fn (r Rational) abs() Rational {
-	return Rational.new(math.abs(r.denominator), math.abs(r.numerator))
+	return Rational.new(math.abs(r.numerator), math.abs(r.denominator))
 }
 
 pub fn (r Rational) add(other Rational) Rational {
-	return Rational.new(r.denominator * other.numerator + other.denominator * r.numerator,
-		r.numerator * other.numerator)
+	return Rational.new(r.numerator * other.denominator + other.numerator * r.denominator,
+		r.denominator * other.denominator)
 }
 
 pub fn (r Rational) div(other Rational) Rational {
@@ -51,7 +51,7 @@ pub fn (r Rational) div(other Rational) Rational {
 // r^n
 pub fn (r Rational) exprational(n i64) Rational {
 	n_pos := math.abs(n)
-	result := Rational.new(powi(r.denominator, n_pos), powi(r.numerator, n_pos))
+	result := Rational.new(powi(r.numerator, n_pos), powi(r.denominator, n_pos))
 
 	return match signi(n) {
 		1 { result }
@@ -61,15 +61,15 @@ pub fn (r Rational) exprational(n i64) Rational {
 
 // n^r
 pub fn (r Rational) expreal(n i64) f64 {
-	return pow(n, f64(r.denominator) / f64(r.numerator))
+	return pow(n, f64(r.numerator) / f64(r.denominator))
 }
 
 pub fn (r Rational) mul(other Rational) Rational {
-	return Rational.new(r.denominator * other.denominator, r.numerator * other.numerator)
+	return Rational.new(r.numerator * other.numerator, r.denominator * other.denominator)
 }
 
 pub fn (r Rational) reduce() Rational {
-	return Rational.new(r.denominator, r.numerator)
+	return Rational.new(r.numerator, r.denominator)
 }
 
 pub fn (r Rational) sub(other Rational) Rational {

exercises/practice/rational-numbers/rational-numbers.v

@@ -4,7 +4,7 @@ struct Rational {
 }
 
 // build a new Rational number
-pub fn Rational.new(denominator i64, numerator i64) Rational {
+pub fn Rational.new(numerator i64, denominator i64) Rational {
 }
 
 pub fn (r Rational) abs() Rational {