Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github(tests): bump macos-12 to macos-13 #428

Merged
merged 2 commits into from
Sep 17, 2024
Merged

.github(tests): bump macos-12 to macos-13 #428

merged 2 commits into from
Sep 17, 2024

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Sep 17, 2024

GitHub dropped macOS-12 support. Workflow needs updating to 14.

See: https://forum.exercism.org/t/github-actions-runner-breaking-changes-announced/12612

@keiravillekode
Copy link
Contributor

Run ./.github/bin/install-zig
Downloading Zig release archive...
curl: (22) The requested URL returned error: ...

We could update .github/bin/install-zig to show the requested url:

echo "Downloading Zig release archive (${url})..." >&2

Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if macos-13 works.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@ee7 ee7 changed the title fix: update macOs workflow .github(tests): bump macos-12 to macos-13 Sep 17, 2024
@ee7 ee7 merged commit c75f81d into exercism:main Sep 17, 2024
7 checks passed
@ee7
Copy link
Member

ee7 commented Sep 17, 2024

CI failed with macos-14 because that changed the macOS job from x86_64 to arm64, and it looks like the install-zig script doesn't support arm64 macOS properly. We can consider fixing that later, or moving to a different zig installation method.

But for now, I've merged this with macos-13, which is still x86_64.

We can still consider adding macos-14 to the matrix later. I'd lean towards running on both arm64 macOS and x86_64 macOS, rather than just one of them.

@vaeng vaeng deleted the fix--update-macOs-workflow branch September 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants