Skip to content

Conversation

costinmrr
Copy link
Member


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@costinmrr costinmrr changed the base branch from fix/pgsql-windows-ci to master November 2, 2021 13:20
@costinmrr costinmrr mentioned this pull request Nov 2, 2021
4 tasks
@costinmrr
Copy link
Member Author

Hooray, it works! :)

@EddyDeegan can you please have a look at the code?

@hongaar how should we proceed with this one? Is it better to open a new PR in the base repo and reference your old PR in the description?

@costinmrr costinmrr requested a review from EddyDeegan November 2, 2021 14:57
@costinmrr costinmrr self-assigned this Nov 2, 2021
@costinmrr costinmrr added the enhancement New feature or request label Nov 2, 2021
@hongaar
Copy link

hongaar commented Nov 2, 2021

Awesome work @costinmrr, glad you were able to get it to work!! 💪
Will this pass their AppVeyor CI/CD?

Let's wait for @EddyDeegan to review and then yes please open a new PR and I'll close the old one, that makes the most sense to me.

Copy link
Member

@EddyDeegan EddyDeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone through it with Costin on Slack - looks great to me based on the fact it works on his system and the code changes look perfectly reasonable to me also!

@costinmrr
Copy link
Member Author

Will this pass their AppVeyor CI/CD?

Of course :P
image

@costinmrr costinmrr force-pushed the feat/pgsql-windows-load-library branch from 2957dff to 4793711 Compare November 4, 2021 09:17
@costinmrr costinmrr force-pushed the feat/pgsql-windows-load-library branch 6 times, most recently from cc6b345 to d7676c1 Compare February 22, 2022 14:16
@costinmrr costinmrr force-pushed the feat/pgsql-windows-load-library branch from d7676c1 to 56eab5b Compare March 1, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants