[ENG-4579] convert eas-cli to ESM #1199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-4579 Convert eas-cli to esm
Screenshot 2022-04-07 at 15.26.32.png We can't convert a bunch of deps in eas-cli because it's not an ESM. It seems that it should be possible to convert eas-cli now https://github.com/typhonjs-oclif-scratch/test-cli-modern/tree/main/src |
|
Size Change: +778 kB (+3%) Total Size: 25.9 MB
|
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]and CHANGELOG.md will be updated automatically.Why
Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.
How
How did you build this feature or fix this bug and why?
Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.