fix: ensure req.cookies defaults to {} when no Cookie header is sent #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in Express 5 environments, req.cookies could remain null when no Cookie header was provided or when an empty Cookie header was sent. This caused unexpected null checks in downstream middleware relying on req.cookies to always be an object. This commit initializes req.cookies to an empty object before early returns, ensuring consistent behavior with Express 4 and maintaining backward compatibility. Closes: expressjs#128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in Express 5 environments, req.cookies could remain null when no Cookie header was provided or when an empty Cookie header was sent. This caused unexpected null checks in downstream middleware relying on req.cookies to always be an object. This commit initializes req.cookies to an empty object before early returns, ensuring consistent behavior with Express 4 and maintaining backward compatibility.
Closes: #128