feat(types): Argument coercion into HashSet/BTreeSet #493

[kakserpom]

Description

Implements #493

[coveralls]

Pull Request Test Coverage Report for Build 20234104119

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 43 of 56 (76.79%) changed or added relevant lines in 4 files are covered.
• 32 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.8%) to 36.015%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/types/array/conversions/btree_set.rs	12	16	75.0%
src/types/array/conversions/hash_set.rs	12	16	75.0%
src/types/array/array_key.rs	5	10	50.0%

Files with Coverage Reduction	New Missed Lines	%
src/types/array/array_key.rs	2	53.06%
crates/macros/src/lib.rs	30	26.92%

Totals
Change from base Build 20110536661:	0.8%
Covered Lines:	1652
Relevant Lines:	4587

---

💛 - Coveralls

[Xenira]

Thanks. Can you add unit tests?

[kakserpom]

I am not sure what should be tested here.

[ptondereau]

Thanks for the implementation! Just some comments.

[ptondereau]

I am not sure what should be tested here.

for example:

#[test]
fn test_hash_table_try_from_hash_set() {
      Embed::run(|| {
          let mut set = HashSet::new();
          set.insert("one");
          let ht: ZBox<ZendHashTable> = set.try_into().unwrap();
          assert_eq!(ht.len(), 1);
          assert!(ht.get(0).is_some());
      });
}

[kakserpom]

@ptondereau @Xenira take a look pls =)

[ptondereau]

LGTM thanks