feat(ui): scroll/entrance animations for landing sections#545
Conversation
|
@TobyKing007 is attempting to deploy a commit to the ezedikeevan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@akinboyewaSamson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ezedike-evan
left a comment
ezedike-evan
left a comment
There was a problem hiding this comment.
This PR can't be merged due to massive scope violation. It's supposed to add scroll animations (closes #524, ~3 files) but the diff touches 50+ files including package-lock.json, docs/ROADMAP.md, docs/ARCHITECTURE.md, README.md, .github/PULL_REQUEST_TEMPLATE.md, and unrelated hooks, lib files, and components across the whole codebase. This looks like your entire fork's accumulated changes submitted in one PR. Please close this PR and resubmit a clean branch that touches only the files needed for scroll animations.
ezedike-evan
left a comment
ezedike-evan
left a comment
There was a problem hiding this comment.
Hi @akinboyewaSamson — this PR touches pnpm-lock.yaml (the lockfile) as part of scroll animations. Please ensure the lockfile change is intentional (a legitimate dependency was added) and add a linked issue using a closing keyword (e.g. Closes #123).
ezedike-evan
left a comment
ezedike-evan
left a comment
There was a problem hiding this comment.
Thanks for the scroll-animation work — the useInView hook + LandingSection wrapper look solid and closes #524 cleanly on their own.
However this PR's diff is much larger than that feature: it includes an unrelated commit (feat(corridors): add support for new corridors in Africa, Latin America…) that pulls in a separate, unmerged corridor feature (touches lib/stellar/*, constants/index.ts, many hooks/components/tests, package-lock.json, and docs like README.md, docs/ARCHITECTURE.md, docs/PROPOSAL.md, docs/ROADMAP.md, docs/STRICT_LINTING.md, .github/OSS_WEEK_CONTRIBUTOR_BOARD.md, .github/PULL_REQUEST_TEMPLATE.md). None of that is needed to close #524.
To fix: rebase this branch on top of current main (not merge), drop/cherry-pick out the corridors commit, and force-push so the diff only contains hooks/useInView.ts, components/landing/LandingSection.tsx, the app/page.tsx staggered-reveal wiring, and their tests. Happy to re-review once it's scoped down.
ezedike-evan
force-pushed
the
feat/B091-scroll-animations
branch
from
b35bfab to
6e6db9b
Compare
ezedike-evan
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…an#524) Wraps Hero, StatBar, CorridorStrip, the module card, explainer, and Faq sections on the landing page in a LandingSection component driven by a useInView (IntersectionObserver) hook. Sections fade/slide in on first scroll into view; prefers-reduced-motion disables the effect at both the JS and CSS level.
ezedike-evan
force-pushed
the
feat/B091-scroll-animations
branch
from
7460629 to
d60a0d5
Compare
3 participants
Closes #524
Rebuilt cleanly on current main after the original branch turned out to be based on a very old commit (predating the Hero/StatBar/CorridorStrip/Faq component extraction, JWT caching, and other work). Same
useInViewhook +LandingSectionwrapper as originally authored by @akinboyewaSamson;app/page.tsxnow wraps the current page structure instead of the old inline sections, and the staleHomePagesnapshot is updated.IntersectionObserver-driven, respects
prefers-reduced-motionat both JS and CSS level. 9/9 tests pass, typecheck/lint/build all clean.