feat(rates): wire SEP-6 as Tier-3 fallback in fetchCorridorRates#598
Conversation
|
@Johnalex-hub is attempting to deploy a commit to the ezedikeevan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Johnalex-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
determined-001
left a comment
There was a problem hiding this comment.
The commitlint check is failing — the commit subject line doesn't follow Conventional Commits format (e.g. length limit or missing type). Please amend the commit message to match the format (e.g. feat(rates): wire SEP-6 as Tier-3 fallback in fetchCorridorRates) and push.
ezedike-evan
left a comment
There was a problem hiding this comment.
The commitlint check is failing — the commit subject line exceeds the 72-character limit. Please shorten it (e.g. feat(rates): wire SEP-6 as Tier-3 fallback in fetchCorridorRates) and push so commitlint goes green.
7b59ebe to
1788ef1
Compare
ezedike-evan
left a comment
There was a problem hiding this comment.
The check (node 20) and check (node 22) jobs are now failing because main's server-rates.ts was refactored to use isAnchorAssetEnabled instead of USDC_ASSET. When CI runs against the merged ref, the import of USDC_ASSET gets dropped but the usage at line 165 remains, causing: error TS2304: Cannot find name 'USDC_ASSET'.
Please rebase this branch on top of main and update server-rates.ts to work with the current API in constants/anchors.ts (i.e. use isAnchorAssetEnabled / resolve the USDC_ASSET reference against the current export surface).
1788ef1 to
dbee765
Compare
dbee765 to
ee59f26
Compare
015a570 to
c06e46d
Compare
ezedike-evan
left a comment
There was a problem hiding this comment.
Thanks @Johnalex-hub for addressing the rebase conflict! The USDC_ASSET import is in place, sep6-fee is correctly wired into the QuotePill display, and all CI checks are green. The SEP-6 Tier-3 fallback in fetchCorridorRates looks clean — closes #439. Merging.
Summary
Implements B006 — wires SEP-6 as Tier-3 fallback in fetchCorridorRates after SEP-38 (Tier-1) and SEP-24 indicative (Tier-2) both fail.
Test plan
Closes #439