feat(ui): Sep6KycForm programmatic SEP-6 KYC form component#599
feat(ui): Sep6KycForm programmatic SEP-6 KYC form component#599Johnalex-hub wants to merge 2 commits into
Conversation
Replaces KycIframe for SEP-6 anchors with a fully programmatic form driven by Sep6FormSchema (B015). Renders text inputs for plain string fields and select dropdowns for choice fields. Inline zod validation on submit — required fields block submission, errors display with aria-describedby/aria-invalid for accessibility. Submit calls the parent onSubmit handler that wires to the state machine; API errors surface inline. 7 tests cover field rendering, validation blocking, successful submission, error clearing, cancel, and submit failure.
|
@Johnalex-hub is attempting to deploy a commit to the ezedikeevan's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Johnalex-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
determined-001
left a comment
There was a problem hiding this comment.
The check (node 20) and check (node 22) CI jobs are failing. Please investigate (likely a Prettier or TypeScript error in this PR's diff), fix, and push so checks go green before this can merge.
ezedike-evan
left a comment
There was a problem hiding this comment.
Two things to address before this can merge:
-
Out-of-scope file —
lib/stellar/sep6-form.tsbelongs to B015 (issue #448, PR #597) not to B021 (#454). Please remove it from this PR and instead stack this branch on top of #597 once that merges (or cherry-pick only the Sep6KycForm component files:components/offramp/Sep6KycForm.tsxandtests/Sep6KycForm.spec.tsx). -
CI failures —
check (node 20)andcheck (node 22)are failing (Prettier formatting issue inlib/stellar/sep6-form.ts). Once the out-of-scope file is removed, this should resolve.
ac4324f to
ae809ca
Compare
ae809ca to
87ee771
Compare
Summary
Implements B021 — replaces KycIframe for SEP-6 anchors with a programmatic Sep6KycForm component driven by the form schema from B015.
Test plan
Closes #454