Merge master into release

.clang-format

@@ -12,6 +12,7 @@ BinPackParameters: true
 BraceWrapping:
   BeforeLambdaBody: true
 ColumnLimit: 100
+InsertBraces: true
 # Note that on versions after 4.0 you need to specify
 # SpaceAfterTemplateKeyword: true
 # which is not an option prior to 4.0. Later versions

.clang-format-ignore

@@ -0,0 +1,2 @@
+# ignore vendored libraries:
+./external/**/*

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,27 +1,28 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
+title: ""
 labels: bug
-assignees: ''
-
+assignees: ""
 ---
 
 **Describe the bug**
 A clear and concise description of what the bug is, a screenshot helps a lot.
 
 **To Reproduce**
 Steps to reproduce the behavior:
- 1. Open the file using `f3d --no-config example.glb`
- 2. step 2
- 3. step 3
+
+1.  Open the file using `f3d --no-config example.glb`
+2.  step 2
+3.  step 3
 
 **Expected behavior**
 A clear and concise description of what you expected to happen.
 
 **System Information:**
- - OS:
- - GPU and GPU driver:
+
+- OS:
+- GPU and GPU driver:
 
 **F3D Information**
 Paste the content of `f3d --version`:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,10 +1,9 @@
 ---
 name: Feature request
 about: Suggest an idea for this project
-title: ''
+title: ""
 labels: enhancement
-assignees: ''
-
+assignees: ""
 ---
 
 **Is your feature request related to a problem? Please describe.**
@@ -21,4 +20,4 @@ Add any other context or screenshots about the feature request here.
 
 **Contribution**
 Please tell us if you are able to contribute (Can you develop this new feature?)
-Don't worry, you can still post a feature request if you cannot contribute!*
+Don't worry, you can still post a feature request if you cannot contribute!

.github/ISSUE_TEMPLATE/help_wanted.md

@@ -1,10 +1,9 @@
 ---
-name: Help wanted
+name: Open to contribution
 about: A maintainer specific template
-title: ''
-labels: help-wanted 
-assignees: ''
-
+title: ""
+labels: help-wanted
+assignees: ""
 ---
 
 **Context**

.github/ISSUE_TEMPLATE/new_release.md

@@ -1,10 +1,9 @@
 ---
 name: New release
 about: An issue to create a new release
-title: ''
+title: ""
 labels: release
-assignees: ''
-
+assignees: ""
 ---
 
 When creating this issue
@@ -32,14 +31,17 @@ Release Candidates :
 - [ ] Locally test the prerelease on macOS (Silicon)
 - [ ] Locally test the prerelease on Windows
 - [ ] Locally test the python wheels on Linux
-- [ ] Locally test the python wheels on macOS (Intel)
+- [ ] Locally test the python wheels on macOS (Silicon)
 - [ ] Locally test the python wheels on Windows
-- [ ] If it fails, fix the issues in `release` branch, copy this paragraph and increment `N`
+- If it fails,
+  - [ ] Fix the issues in `release` branch,
+  - [ ] Edit this issuethis paragraph and increment `N`
+  - [ ] Merge F3D release into master: https://github.com/f3d-app/f3d/compare/master...release
 - [ ] Else proceed to the next part
 
 Release :
 
-- [ ] Commit, review and merge `vX.Y.Z` version change in https://github.com/f3d-app/f3d `CMakeLists.txt`, `pyproject.toml` and the multiple `doxygen\conf.py` in the `release` branch
+- [ ] Commit, review and merge `vX.Y.Z` version change in https://github.com/f3d-app/f3d `CMakeLists.txt`, `pyproject.toml`, `webassembly/package.json` and the multiple `doxygen\conf.py` in the `release` branch
 - [ ] Tag `vX.Y.Z` and push it to https://github.com/f3d-app/f3d: `git tag vX.Y.Z -m vX.Y.Z`
 - [ ] Commit, review and merge adding `X.Y.Z` in https://github.com/f3d-app/f3d-superbuild `versions.cmake` in the `main` branch
 - [ ] Tag `vX.Y.Z` and push it to https://github.com/f3d-app/f3d-superbuild: `git tag vX.Y.Z -m vX.Y.Z`
@@ -53,36 +55,45 @@ Release :
 - [ ] Communicate on hackernews
 - [ ] Communicate on linkedin
 - [ ] Communicate on mastodon
+
+- [ ] Merge F3D release into master: https://github.com/f3d-app/f3d/compare/master...release- [ ] Communicate on bluesky
 - [ ] Move all issue from current milestone to next milestone, close current roadmap issue and open a next roadmap issue
 - [ ] Update `doc/dev/ROADMAPS_AND_RELEASES.md` for next release
 - [ ] Create an issue for updating dependencies in CI and superbuild
 - [ ] Update `.github/ISSUE_TEMPLATE/new_release.md` in https://github.com/f3d-app/f3d if needed
 
 Linux testing protocol:
+
 - Install F3D-X.Y.Z-RCN-Linux-x86_64-raytracing system wide
 - `f3d testing/data/cow.vtp` -> check render, orientation, press R and check raytracing
 - `f3d testing/data/f3d.stp` -> check render, orientation
+- `f3d testing/data/f3d.glb` -> press "Space", check animation is going smoothly and takes 4 seconds
 - `f3d /path/to/any/new/file.format` -> check render
 - `rm -rf ~/.cache/thumbnails`
 - `pcmanfm` (or another supported file manager)
 - Check that all supported files in testing/data have a generated thumbnails, especially for new file formats if any
 - Double click on supported file in testing/data, especially for new file formats if any and check it opens in F3D
 - Drag&Drop cow.vtp, Drag&Drop palermo_park.hdr, check render
 - Check that CTRL+O (file dialog) is working
+- Press "Esc" and check the following commands `reload_current_file_group`, `set_camera top`, `toggle_volume_rendering`, `exit`
 - `cd examples/libf3d && mkdir build && cd build && cmake ../ && make`
 - `./cpp/check-engine/check-engine`
 - `./cpp/render-interact/render-interact ../../../testing/data/cow.vtp`
 
 macOS testing protocol:
+
 - Install F3D-X.Y.Z-RCN-macOS-x86_64-raytracing.dmg
 - Double click on cow.vtp, check render and orientation, press R and check raytracing
 - Double click on f3d.stp, check render and orientation
+- Double click on f3d.glb, press "Space", check animation is going smoothly and takes 4 seconds
 - Double click on any new supported file.format, check render
 - Check all supported file in testing/data directory in finder have the f3d mark, if not, check that "open with" suggest F3D
 - Drag&Drop cow.vtp, Drag&Drop palermo_park.hdr, check render
 - Check that CTRL+O (file dialog) is working
+- Press "Esc" and check the following commands `reload_current_file_group`, `set_camera top`, `toggle_volume_rendering`, `exit`
 
 Windows testing protocol:
+
 - Install F3D-X.Y.Z-RCN-Windows-x86_64-raytracing.exe, add F3D to path for all users
 - Start -> Disk Cleanup -> select thumbnails -> Ok -> Delete Files
 - Open testing/data directory in file manager
@@ -91,20 +102,28 @@ Windows testing protocol:
 - Check that every supported file has a small "f3d" mark, for those that don't check that "Open with" -> "Use another app" suggest F3D.
 - Double click on cow.vtp, check render and orientation, press R and check raytracing
 - Double click on f3d.stp, check render and orientation
+- Double click on f3d.glb, press "Space", check animation is going smoothly and takes 4 seconds
 - Double click on any new supported file format, check render
 - Check that CTRL+O (file dialog) is working
+- Press "Esc" and check the following commands `reload_current_file_group`, `set_camera top`, `toggle_volume_rendering`, `exit`
 - `cd examples\libf3d && mkdir build && cd build && cmake ../ && cmake --build . --config Release`
 - `.\cpp\check-engine\Release\check-engine`
 - `.\cpp\render-interact\Release\render-interact ..\..\..\testing\data\cow.vtp`
 
 Python testing protocol:
+
 - Use a venv or make sure f3d is not installed in your python environment
 - pip install f3d==X.Y.Z-RCN
 - python
+
 ```
 import f3d
-eng = f3d.Engine(f3d.Window.NATIVE)
-eng.loader.load_geometry("/path/to/cow.vtp")
-eng.window.render()
+eng = f3d.Engine.create()
+eng.scene.add("/path/to/cow.vtp")
+eng.window.render() # No effect on Windows
 eng.interactor.start()
 ```
+
+- Check the following
+  - The name of the window is `f3d` at all time
+  - Python provides suggestions whenever the "Tab" key is pressed

.github/actions/alembic-install-dep/action.yml

@@ -5,26 +5,33 @@ inputs:
     description: 'CPU architecture to build for'
     required: false
     default: 'x86_64'
-
+  version:
+    description: 'Version of alembic to build'
+    required: true
+
 runs:
   using: "composite"
   steps:
 
-    # Alembic is part of VFX reference platform (CY2025: 1.8.x)
+    - name: Check required inputs
+      shell: bash
+      run: |
+        [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
+
     - name: Cache Alembic
       id: cache-alembic
-      uses: actions/cache@v4
+      uses: actions/cache/restore@v4
       with:
         path: dependencies/alembic_install
-        key: alembic-v1.8.8-${{runner.os}}-${{inputs.cpu}}-0
+        key: alembic-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-0
 
     - name: Checkout Alembic
       if: steps.cache-alembic.outputs.cache-hit != 'true'
       uses: actions/checkout@v4
       with:
         repository: alembic/alembic
         path: './dependencies/alembic'
-        ref: 1.8.8
+        ref: ${{inputs.version}}
 
     - name: Setup Alembic
       if: steps.cache-alembic.outputs.cache-hit != 'true'
@@ -60,3 +67,10 @@ runs:
       working-directory: ${{github.workspace}}/dependencies/alembic_install
       shell: bash
       run: cp -r ./* ../install/
+
+    - name: Save cache
+      if: steps.cache-alembic.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        key: ${{ steps.cache-alembic.outputs.cache-primary-key }}
+        path: dependencies/alembic_install

.github/actions/android-ci/action.yml

@@ -4,18 +4,6 @@ inputs:
   arch:
     description: 'Android arch to build'
     required: true
-  ndk_version:
-    description: 'Version of the Android NDK to download'
-    required: false
-    default: 'r26b'
-  api_level:
-    description: 'Android API level'
-    required: false
-    default: '27'
-  vtk_version:
-    description: 'VTK version'
-    required: false
-    default: 'commit'
 
 runs:
   using: "composite"
@@ -26,28 +14,6 @@ runs:
       run: |
         [[ "${{inputs.arch}}" ]] || { echo "arch input is empty" ; exit 1; }
 
-    - name: Dependencies Dir
-      shell: bash
-      working-directory: ${{github.workspace}}
-      run: mkdir dependencies
-
-    - name: Install NDK
-      shell: bash
-      working-directory: ${{github.workspace}}
-      run: |
-        apt-get install unzip
-        wget https://dl.google.com/android/repository/android-ndk-${{inputs.ndk_version}}-linux.zip
-        unzip -qq android-ndk-${{inputs.ndk_version}}-linux.zip
-        mv android-ndk-${{inputs.ndk_version}} android-ndk
-
-    - name: Install VTK dependency
-      uses: ./source/.github/actions/vtk-android-install-dep
-      with:
-        arch: ${{inputs.arch}}
-        api_level: ${{inputs.api_level}}
-        vtk_version: ${{inputs.vtk_version}}
-        vtk_sha_file: ./source/.github/actions/vtk_commit_sha
-
     - name: Setup Directories
       shell: bash
       working-directory: ${{github.workspace}}
@@ -60,16 +26,17 @@ runs:
       working-directory: ${{github.workspace}}/build
       run: >
         cmake ../source
-        -DCMAKE_ANDROID_ARCH_ABI=${{inputs.arch}}
-        -DCMAKE_ANDROID_NDK=$(pwd)/../android-ndk
         -DCMAKE_BUILD_TYPE=Release
-        -DCMAKE_FIND_ROOT_PATH=$(pwd)/../dependencies/vtk_build/CMakeExternals/Install/vtk-android/
         -DCMAKE_INSTALL_PREFIX:PATH=../install
-        -DCMAKE_SYSTEM_NAME=Android
-        -DCMAKE_SYSTEM_VERSION=${{inputs.api_level}}
         -DF3D_BINDINGS_JAVA=ON
+        -DF3D_MODULE_EXR=ON
         -DF3D_MODULE_UI=OFF
+        -DF3D_PLUGINS_STATIC_BUILD=ON
+        -DF3D_PLUGIN_BUILD_ALEMBIC=ON
+        -DF3D_PLUGIN_BUILD_ASSIMP=ON
+        -DF3D_PLUGIN_BUILD_DRACO=ON
         -DF3D_PLUGIN_BUILD_EXODUS=OFF
+        -DF3D_PLUGIN_BUILD_OCCT=ON
         -DF3D_STRICT_BUILD=ON
 
     - name: Build

.github/actions/assimp-install-dep/action.yml

@@ -5,29 +5,42 @@ inputs:
     description: 'CPU architecture to build for'
     required: false
     default: 'x86_64'
+  version:
+    description: 'Version of assimp to build'
+    required: true
 
 runs:
   using: "composite"
   steps:
 
+    - name: Check required inputs
+      shell: bash
+      run: |
+        [[ "${{ inputs.version }}" ]] || { echo "version input is empty" ; exit 1; }
+
     - name: Cache ASSIMP
       id: cache-assimp
-      uses: actions/cache@v4
+      uses: actions/cache/restore@v4
       with:
         path: dependencies/assimp_install
-        key: assimp-v5.4.3-${{runner.os}}-${{inputs.cpu}}-0
+        key: assimp-${{inputs.version}}-${{runner.os}}-${{inputs.cpu}}-0
 
     - name: Checkout ASSIMP
       if: steps.cache-assimp.outputs.cache-hit != 'true'
       uses: actions/checkout@v4
       with:
         repository: assimp/assimp
         path: './dependencies/assimp'
-        ref: v5.4.3
+        ref: ${{inputs.version}}
 
-    # Revert https://github.com/assimp/assimp/pull/5349
+    # Revert: https://github.com/assimp/assimp/pull/5349
+    # Issue: https://github.com/assimp/assimp/issues/5449
+    # Fix: https://github.com/assimp/assimp/pull/5751
+    # This impact 5.4.3 and should be fixed in next release (5.5 or 5.4.4)
     - name: Patch ASSIMP
-      if: steps.cache-assimp.outputs.cache-hit != 'true'
+      if: |
+        steps.cache-assimp.outputs.cache-hit != 'true' &&
+        inputs.version == 'v5.4.3'
       working-directory: ${{github.workspace}}/dependencies/assimp
       shell: bash
       run: patch -p1 < $GITHUB_ACTION_PATH/assimp-revert-fbx-bone-anim.patch
@@ -74,3 +87,10 @@ runs:
       working-directory: ${{github.workspace}}/dependencies/assimp_install
       shell: bash
       run: cp -r ./* ../install/
+
+    - name: Save cache
+      if: steps.cache-assimp.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        key: ${{ steps.cache-assimp.outputs.cache-primary-key }}
+        path: dependencies/assimp_install

.github/actions/blosc-install-dep/action.yml

@@ -12,10 +12,10 @@ runs:
 
     - name: Cache blosc
       id: cache-blosc
-      uses: actions/cache@v4
+      uses: actions/cache/restore@v4
       with:
         path: dependencies/blosc_install
-        key: blosc-1.21.6-${{runner.os}}-${{inputs.cpu}}-0
+        key: blosc-v1.21.6-${{runner.os}}-${{inputs.cpu}}-0
 
     # Dependents: openvdb vtk
     - name: Checkout blosc
@@ -62,3 +62,10 @@ runs:
       working-directory: ${{github.workspace}}/dependencies/blosc_install
       shell: bash
       run: cp -r ./* ../install/
+
+    - name: Save cache
+      if: steps.cache-blosc.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        key: ${{ steps.cache-blosc.outputs.cache-primary-key }}
+        path: dependencies/blosc_install