Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Update Spring Boot to 2.4.9 #418

Conversation

jacobdotcosta
Copy link
Contributor

No description provided.

@centos-ci
Copy link

Can one of the admins verify this patch?

@quintesse
Copy link
Contributor

[test]

@quintesse
Copy link
Contributor

Still getting errors it seems...

@jacobdotcosta
Copy link
Contributor Author

The problem seems to be the junit version.

[INFO] Compiling 1 source file to /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/target/test-classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[21,17] package org.junit does not exist
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[22,17] package org.junit does not exist
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[23,24] package org.junit.runner does not exist
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[30,2] cannot find symbol
  symbol: class RunWith
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[42,6] cannot find symbol
  symbol:   class Before
  location: class dev.snowdrop.example.NameEndpointTest
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[47,6] cannot find symbol
  symbol:   class Test
  location: class dev.snowdrop.example.NameEndpointTest
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[52,6] cannot find symbol
  symbol:   class Test
  location: class dev.snowdrop.example.NameEndpointTest
[ERROR] /tmp/junit8379195045101937131/spring-boot/booster4266474215477127666/name-service/src/test/java/dev/snowdrop/example/NameEndpointTest.java:[57,6] cannot find symbol
  symbol:   class Test
  location: class dev.snowdrop.example.NameEndpointTest
[INFO] 8 errors 

@quintesse is there the possibility of using a junit 5 capable system for this example?

@quintesse
Copy link
Contributor

@jacobdotcosta it's your code so you people can do with it what you want :-)
Just make sure it compiles before you create the PR because the problem is simply that it doesn't compile, not even when I clone it locally and simply run ./mvn package.

@jacobdotcosta
Copy link
Contributor Author

I see the problem. It should be using example version 2.4.9-9 instead of 2.4.9-8. I apologize for this.

@jacobdotcosta jacobdotcosta self-assigned this Nov 10, 2021
@jacobdotcosta jacobdotcosta deleted the update-to-spring-boot-2.4.9 branch November 10, 2021 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants