-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAVA_MAJOR_VERSION #219
Conversation
@muff1nman I think this is going in the right direction and I'm in favour of this, but: Similarly to the previous discussion over in #217, you cannot (only) change the Instead, change the s2i/java/templates/Dockerfile and use a variable you set in s2i/java/images.yml. Perhaps you'll just want to use the already existing (which I introduced...) Does this make sense and do you think you can do this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments above for why this needs some adjustments until we can (and want to!) merge it
I agree with @vorburger . Installing fish-pepper might be a pain, so I recommend to run it from within a Docker container like in
(of course you need to able to use volume mounts) See also https://github.com/fabric8io-images/fish-pepper/tree/master/docker |
c8898da
to
716a087
Compare
@vorburger Ended up going with a second variable to be explicit. |
OK for me... in an ideal world, you would also contribute an extension to
but don't you have to bump the version of run-java-sh in |
@muff1nman do you want to finish this one up? I think following #123 which bumped run-java-sh you just have to debase this on the latest master now, and then it will work.. |
204feae
to
1e4add7
Compare
@vorburger Rebased. I tested it and after increasing the |
Signed-off-by: Andrew DeMaria <[email protected]>
1e4add7
to
1f8619e
Compare
In combination with fabric8io-images/run-java-sh#78, this should resolve #213.