Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing duplicate ExchangesTotal #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shawkins
Copy link

No description provided.

@jamesnetherton
Copy link
Contributor

I don't think they are duplicates as such. Camel exposes the ExchangesTotal metric for:

  • Camel Contexts
  • Camel Routes
  • Camel Processors

If you're only interested in the total exchanges for the lifetime of the application, you can query using the type label. E.g:

org_apache_camel_ExchangesTotal{type="context"}

@shawkins
Copy link
Author

Yes, there are currently a total of 6 ExchangesTotal entries, two each for contexts, routes, and processors - which appear to be duplicates.

@jamesnetherton
Copy link
Contributor

Can you show an example of this happening? E.g the output from:

curl -s localhost:9779/metrics | grep ExchangesTotal

@shawkins
Copy link
Author

It does not create duplicate entries at runtime. No warning or errors are emitted from the agent. There are simply duplicate entries in the config, see the context duplicates:

- pattern: 'org.apache.camel<context=([^,]+), type=context, name="([^"]+)"><>ExchangesTotal'

- pattern: 'org.apache.camel<context=([^,]+), type=context, name="([^"]+)"><>ExchangesTotal'

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution (sorry for the very late response). You are right, this are duplicated entries, but its in a dependent file which comes (I think) from agent-bond. We need to fix this there first and then recreating the files here with fish-pepper.

I will check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants