[pytx] fix broken gh actions for pytest and lint #1254
Conversation
github-actions
bot
added
the
python-threatexchange
| @@ -272,7 +272,7 @@ class SignalExchangeAPIWithSimpleUpdates( | |||
| state.TFetchCheckpoint, | |||
| state.TFetchedSignalMetadata, | |||
| t.Tuple[str, str], | |||
| state.TFetchedSignalMetadata, | |||
| t.Any, | |||
There was a problem hiding this comment.
@Dcallies I'm not sure on the typing here. All changes besides t.Any expanded to 10 more errors where SignalExchangeAPIWithSimpleUpdates is being used.
There was a problem hiding this comment.
Hmm, this is definitely not right here, the other option is to just # type: ignore for now
There was a problem hiding this comment.
I can't get mypy to understand the # type: ignore directive here. No matter where I put it (above, same line, below as part of class) it get a version of the following:
threatexchange/exchanges/signal_exchange_api.py:269: error: Variance of TypeVar "state.TFetchedSignalMetadata" incompatible with variance in parent type [type-var]
threatexchange/exchanges/signal_exchange_api.py:277: error: Unused "type: ignore" comment
There was a problem hiding this comment.
Synced offline, as ignore was not working I will merge as t.Any but created high-pri issue #1255
| @@ -72,7 +72,7 @@ def assert_cli_output( | |||
| assert lines[line] == expected_line_output | |||
|
|
|||
| def assert_cli_usage_error( | |||
| self, args: t.Iterable[str], msg_regex: str = None | |||
| self, args: t.Iterable[str], msg_regex: str = "" | |||
| ) -> None: | |||
| with pytest.raises((CommandError, E2ETestSystemExit), match=msg_regex) as ex: | |||
There was a problem hiding this comment.
| @@ -272,7 +272,7 @@ class SignalExchangeAPIWithSimpleUpdates( | |||
| state.TFetchCheckpoint, | |||
| state.TFetchedSignalMetadata, | |||
| t.Tuple[str, str], | |||
| state.TFetchedSignalMetadata, | |||
| t.Any, | |||
There was a problem hiding this comment.
Hmm, this is definitely not right here, the other option is to just # type: ignore for now
Summary
Unfortunately the test breaking were not showing up locally, so I used a dev container to get a close as possible to the gh action ENV so I could repro and fix.
Test Plan
py.test and gh actions