[minipack3n] Add presenceDetection for FCB/PDB slot in platform_manager #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.json Description: 1) Add the `presenceDetection` entry for the below slots in platform_manager.json PDBLEFT_SLOT PDBRIGHT_SLOT FCBBOTTOM_SLOT FCBTOP_SLOT Motivation: 1) The presenceDetection for the PDB/FCB slots are missing. 1) Add `psu_l_present` for `PDBLEFT_SLOT` 2) Add `psu_r_present` for `PDBRIGHT_SLOT` 3) Add `fan[2|4|6|8]_present` for `FCBBOTTOM_SLOT` 4) Add `fan[1|3|5|7]_present` for `FCBTOP_SLOT` Test Plan: 1) Run `platform_manager` with the updated configuration. 2) Plug in all FANs and PSUs, then verify that all FCB and PDB slots are explored successfully. [20250313_ALL_(FAN_PSU)_present_.txt](https://github.com/user-attachments/files/19223588/20250313_ALL_.FAN_PSU._present_.txt) 3) Remove the left PSU and verify that `PDBLEFT_SLOT` fails during exploration. [20250313_PDB_L_not_present.txt](https://github.com/user-attachments/files/19223616/20250313_PDB_L_not_present.txt) 4) Remove the right PSU and verify that `PDBRIGHT_SLOT` fails during exploration. [20250313_PDB_R_not_present.txt](https://github.com/user-attachments/files/19223618/20250313_PDB_R_not_present.txt) 5) Remove fans 1/3/5/7 and verify that `FCBTOP_SLOT` fails during exploration. [20250313_FCB_T_FAN_1_not_present.txt](https://github.com/user-attachments/files/19223623/20250313_FCB_T_FAN_1_not_present.txt) [20250313_FCB_T_FAN_3_not_present.txt](https://github.com/user-attachments/files/19223634/20250313_FCB_T_FAN_3_not_present.txt) [20250313_FCB_T_FAN_5_not_present.txt](https://github.com/user-attachments/files/19223727/20250313_FCB_T_FAN_5_not_present.txt) [20250313_FCB_T_FAN_7_not_present.txt](https://github.com/user-attachments/files/19223728/20250313_FCB_T_FAN_7_not_present.txt) 6) Remove fans 2/4/6/8 and verify that `FCBBOTTOM_SLOT` fails during exploration. [20250313_FCB_B_FAN_2_not_present.txt](https://github.com/user-attachments/files/19223730/20250313_FCB_B_FAN_2_not_present.txt) [20250313_FCB_B_FAN_4_not_present.txt](https://github.com/user-attachments/files/19223731/20250313_FCB_B_FAN_4_not_present.txt) [20250313_FCB_B_FAN_6_not_present.txt](https://github.com/user-attachments/files/19223732/20250313_FCB_B_FAN_6_not_present.txt) [20250313_FCB_B_FAN_8_not_present.txt](https://github.com/user-attachments/files/19223733/20250313_FCB_B_FAN_8_not_present.txt)
|
Thanks for the thorough testings |
|
@kimdo8736 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kimdo8736
reviewed
Mar 14, 2025
| @@ -2748,12 +2748,26 @@ | |||
| }, | |||
| "PDBLEFT_SLOT@0": { | |||
| "slotType": "PDBLEFT_SLOT", | |||
| "presenceDetection": { | |||
There was a problem hiding this comment.
Can you please:
- Define PSU(LEFT | RIGHT) PmUnit.
- Add the above PmUnits' IDPROM config with corresponding PSU eeprom.
kimdo8736
reviewed
Mar 14, 2025
Comment on lines
+2790
to
+2835
| "presenceDetection": { | ||
| "sysfsFileHandle": { | ||
| "devicePath": "/[MCB_FAN_CPLD]", | ||
| "presenceFileName": "fan2_present", | ||
| "desiredValue": 1 | ||
| } | ||
| }, | ||
| "outgoingI2cBusNames": [ | ||
| "MCB_IOB_I2C_MASTER_17" | ||
| ] | ||
| }, | ||
| "FCBBOTTOM_SLOT@1": { | ||
| "slotType": "FCBBOTTOM_SLOT", | ||
| "presenceDetection": { | ||
| "sysfsFileHandle": { | ||
| "devicePath": "/[MCB_FAN_CPLD]", | ||
| "presenceFileName": "fan4_present", | ||
| "desiredValue": 1 | ||
| } | ||
| }, | ||
| "outgoingI2cBusNames": [ | ||
| "MCB_IOB_I2C_MASTER_17" | ||
| ] | ||
| }, | ||
| "FCBBOTTOM_SLOT@2": { | ||
| "slotType": "FCBBOTTOM_SLOT", | ||
| "presenceDetection": { | ||
| "sysfsFileHandle": { | ||
| "devicePath": "/[MCB_FAN_CPLD]", | ||
| "presenceFileName": "fan6_present", | ||
| "desiredValue": 1 | ||
| } | ||
| }, | ||
| "outgoingI2cBusNames": [ | ||
| "MCB_IOB_I2C_MASTER_17" | ||
| ] | ||
| }, | ||
| "FCBBOTTOM_SLOT@3": { | ||
| "slotType": "FCBBOTTOM_SLOT", | ||
| "presenceDetection": { | ||
| "sysfsFileHandle": { | ||
| "devicePath": "/[MCB_FAN_CPLD]", | ||
| "presenceFileName": "fan8_present", | ||
| "desiredValue": 1 | ||
| } | ||
| }, |
There was a problem hiding this comment.
Looks like physically one FCB to 4 Fans.
Can you create a separate PmUnit for "FAN" (you need 4), then define presence detection in FCB's outgoingSlotConfigs?
somasun
requested changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
presenceDetectionentry for the below slots in platform_manager.jsonPDBLEFT_SLOT
PDBRIGHT_SLOT
FCBBOTTOM_SLOT
FCBTOP_SLOT
Motivation:
psu_l_presentforPDBLEFT_SLOTpsu_r_presentforPDBRIGHT_SLOTfan[2|4|6|8]_presentforFCBBOTTOM_SLOTfan[1|3|5|7]_presentforFCBTOP_SLOTTest Plan:
platform_managerwith the updated configuration.20250313_ALL_(FAN_PSU)present.txt
PDBLEFT_SLOTfails during exploration.20250313_PDB_L_not_present.txt
PDBRIGHT_SLOTfails during exploration.20250313_PDB_R_not_present.txt
FCBTOP_SLOTfails during exploration.20250313_FCB_T_FAN_1_not_present.txt
20250313_FCB_T_FAN_3_not_present.txt
20250313_FCB_T_FAN_5_not_present.txt
20250313_FCB_T_FAN_7_not_present.txt
FCBBOTTOM_SLOTfails during exploration.20250313_FCB_B_FAN_2_not_present.txt
20250313_FCB_B_FAN_4_not_present.txt
20250313_FCB_B_FAN_6_not_present.txt
20250313_FCB_B_FAN_8_not_present.txt