Skip to content

Commit

Permalink
Rm implementation-detail test
Browse files Browse the repository at this point in the history
Summary: After discussion with ot, we agree that this diff is only testing implementation details, and based on D45446476 those details are impractical to test. The obvious result: delete the test.

Reviewed By: ot

Differential Revision: D45571582

fbshipit-source-id: 5f5c11ef22c87ecb91830104feb5d0215e19b9fb
  • Loading branch information
Gownta authored and facebook-github-bot committed May 4, 2023
1 parent 7eef318 commit 1e65798
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions folly/experimental/test/TimekeeperHighResTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -425,28 +425,6 @@ TEST(Timekeeper, semiFutureWithinChainedInterruptTest) {
EXPECT_TRUE(test);
}

TEST(Timekeeper, executor) {
class ExecutorTester : public DefaultKeepAliveExecutor {
public:
~ExecutorTester() override { joinKeepAlive(); }
virtual void add(Func f) override {
count++;
f();
}
std::atomic<int> count{0};
};

Promise<Unit> p;
ExecutorTester tester;
auto f = p.getFuture()
.via(&tester)
.within(milliseconds(100))
.thenValue([&](auto&&) {});
p.setValue();
f.wait();
EXPECT_EQ(3, tester.count);
}

// TODO(5921764)
/*
TEST(Timekeeper, onTimeoutPropagates) {
Expand Down

0 comments on commit 1e65798

Please sign in to comment.