Skip to content

Commit

Permalink
Revert D41478154: Multisect successfully blamed D41478154 for test or…
Browse files Browse the repository at this point in the history
… build failures

Summary:
This diff is reverting D41478154 (bca372d)
D41478154 (bca372d) has been identified to be causing the following test or build failures:
Tests affected:
- https://www.internalfb.com/intern/test/281475050179222/
- https://www.internalfb.com/intern/test/281475050179220/

Here's the Multisect link:
https://www.internalfb.com/intern/testinfra/multisect/1431791
Here are the tasks that are relevant to this breakage:
T93275607: 2 tests started failing for oncall async_tier in the last 2 weeks
We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.

Differential Revision: D41523287

fbshipit-source-id: c20ef74ea52d400c6d40f8bd8bba9351f3109fa0
  • Loading branch information
Dark Knight authored and facebook-github-bot committed Nov 25, 2022
1 parent 5984d57 commit 6ed3611
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions folly/io/async/Request.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <folly/io/async/Request.h>

#include <folly/GLog.h>
#include <folly/Indestructible.h>
#include <folly/MapUtil.h>
#include <folly/experimental/SingleWriterFixedHashMap.h>
#include <folly/synchronization/Hazptr.h>
Expand Down Expand Up @@ -655,8 +654,8 @@ RequestContext::setShallowCopyContext() {
/* static */ RequestContext* RequestContext::get() {
auto& context = getStaticContext().requestContext;
if (!context) {
static Indestructible<RequestContext> defaultContext{0};
return defaultContext.get();
static RequestContext defaultContext(0);
return std::addressof(defaultContext);
}
return context.get();
}
Expand Down

0 comments on commit 6ed3611

Please sign in to comment.