Clean up unused createStoreOwnPropertyInst

Summary:
We have 4 diferent versions of createStoreOwnPropertyInst, defined in different places in IRBuilder.h.
Only 2 are used and one of them only has one occurance. Those definitions seem unnecessary to me and only increase the complexity of the API.
Clean them up

Reviewed By: dulinriley

Differential Revision: D16496423

fbshipit-source-id: 0eba772aac774921d4fcd4463cdfa5f96db4ea83

include/hermes/IR/IRBuilder.h

@@ -317,12 +317,6 @@ class IRBuilder {
       LiteralString *property,
       PropEnumerable isEnumerable);
 
-  StoreOwnPropertyInst *createStoreOwnPropertyInst(
-      Value *storedValue,
-      Value *object,
-      int index,
-      PropEnumerable isEnumerable);
-
   StoreGetterSetterInst *createStoreGetterSetterInst(
       Value *storedGetter,
       Value *storedSetter,
@@ -341,11 +335,6 @@ class IRBuilder {
       Value *storedValue,
       Value *object,
       StringRef property);
-  StoreOwnPropertyInst *createStoreOwnPropertyInst(
-      Value *storedValue,
-      Value *object,
-      StringRef property,
-      PropEnumerable isEnumerable);
 
   DeletePropertyInst *createDeletePropertyInst(
       Value *object,
@@ -362,11 +351,6 @@ class IRBuilder {
   TryStoreGlobalPropertyInst *createTryStoreGlobalPropertyInst(
       Value *storedValue,
       Identifier property);
-  StoreOwnPropertyInst *createStoreOwnPropertyInst(
-      Value *storedValue,
-      Value *object,
-      Identifier property,
-      PropEnumerable isEnumerable);
 
   AllocObjectInst *createAllocObjectInst(
       uint32_t size,

lib/IR/IRBuilder.cpp

@@ -431,15 +431,6 @@ StoreNewOwnPropertyInst *IRBuilder::createStoreNewOwnPropertyInst(
   return inst;
 }
 
-StoreOwnPropertyInst *IRBuilder::createStoreOwnPropertyInst(
-    Value *storedValue,
-    Value *object,
-    int index,
-    PropEnumerable isEnumerable) {
-  return createStoreOwnPropertyInst(
-      storedValue, object, this->getLiteralNumber(index), isEnumerable);
-}
-
 StoreGetterSetterInst *IRBuilder::createStoreGetterSetterInst(
     Value *storedGetter,
     Value *storedSetter,
@@ -482,14 +473,6 @@ StorePropertyInst *IRBuilder::createStorePropertyInst(
   Identifier Iden = createIdentifier(property);
   return createStorePropertyInst(storedValue, object, Iden);
 }
-StoreOwnPropertyInst *IRBuilder::createStoreOwnPropertyInst(
-    Value *storedValue,
-    Value *object,
-    StringRef property,
-    PropEnumerable isEnumerable) {
-  Identifier Iden = createIdentifier(property);
-  return createStoreOwnPropertyInst(storedValue, object, Iden, isEnumerable);
-}
 
 LoadPropertyInst *IRBuilder::createLoadPropertyInst(
     Value *object,
@@ -530,15 +513,6 @@ TryStoreGlobalPropertyInst *IRBuilder::createTryStoreGlobalPropertyInst(
   return inst;
 }
 
-StoreOwnPropertyInst *IRBuilder::createStoreOwnPropertyInst(
-    Value *storedValue,
-    Value *object,
-    Identifier property,
-    PropEnumerable isEnumerable) {
-  auto L = getLiteralString(property);
-  return createStoreOwnPropertyInst(storedValue, object, L, isEnumerable);
-}
-
 AllocObjectInst *IRBuilder::createAllocObjectInst(
     uint32_t size,
     Value *parent) {

lib/IRGen/ESTreeIRGen-expr.cpp

@@ -238,7 +238,10 @@ Value *ESTreeIRGen::genArrayExpr(ESTree::ArrayExpressionNode *Expr) {
         elements.push_back(value);
       } else {
         Builder.createStoreOwnPropertyInst(
-            value, allocArrayInst, count, IRBuilder::PropEnumerable::Yes);
+            value,
+            allocArrayInst,
+            Builder.getLiteralNumber(count),
+            IRBuilder::PropEnumerable::Yes);
       }
     }
     count++;