Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forecaster.py #2514

Closed
wants to merge 3 commits into from
Closed

Update forecaster.py #2514

wants to merge 3 commits into from

Conversation

LiceyMaxim
Copy link

make_future_dataframe
Change description, removed unnecessary comments and operations

make_future_dataframe
Change description, removed unnecessary comments and operations
@facebook-github-bot
Copy link
Contributor

Hi @LiceyMaxim!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@LiceyMaxim
Copy link
Author

Add Facebook CLA

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

remove inplace
@tcuongd
Copy link
Collaborator

tcuongd commented Nov 6, 2023

It seems like the tests are failing. Could you take a look and see if it's related to your change? Thanks!

@tcuongd tcuongd self-requested a review November 6, 2023 09:53
@LiceyMaxim
Copy link
Author

@tcuongd Could you please check my pr?

@tcuongd
Copy link
Collaborator

tcuongd commented May 18, 2024

Thanks, could you please update the description with what scenarios this would solve and the before/after? Or do you mainly just want to get rid of the inplace operation? I see you've also removed the dates = dates[:periods] line.

@tcuongd tcuongd closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants