Skip to content

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Oct 21, 2025

part of #52

@meta-cla meta-cla bot added the cla signed label Oct 21, 2025
@yangdanny97
Copy link
Contributor

Running test.py should generate some changes, could you please include them in the commit?

@asukaminato0721 asukaminato0721 marked this pull request as ready for review October 21, 2025 03:43
"typeddicts_readonly_consistency.py": [],
"typeddicts_readonly_inheritance.py": [
"Line 98: Expected 1 errors",
"Line 106: Expected 1 errors",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I don't think this fully fixes #52, we also have to apply these rules in multiple inheritance.

The code pointer for that is

pub fn check_consistent_multiple_inheritance(&self, cls: &Class, errors: &ErrorCollector) {

Copy link
Contributor

@yangdanny97 yangdanny97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to you with a few comments

@asukaminato0721 asukaminato0721 marked this pull request as ready for review October 23, 2025 04:43
@meta-codesync
Copy link

meta-codesync bot commented Oct 23, 2025

@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D85366496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants