Conversation
Summary: String-form LSP glob patterns require forward slashes, but root watcher patterns use the platform separator. D120727301 exposed this on Windows when it re-registered a newly added search path and the emitted glob contained backslashes. Normalize separators in fallback string globs. Keep literal backslashes unchanged on Unix, where they are not path separators. Differential Revision: D121115651
Contributor
|
@stroxler has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121115651. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
This pull request has been merged in 3106284. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
String-form LSP glob patterns require forward slashes, but root watcher patterns use the platform separator. D120727301 exposed this on Windows when it re-registered a newly added search path and the emitted glob contained backslashes.
Normalize separators in fallback string globs. Keep literal backslashes unchanged on Unix, where they are not path separators.
Differential Revision: D121115651