-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add headers support when passing source array #32863
Open
marcesengel
wants to merge
8
commits into
facebook:main
Choose a base branch
from
marcesengel:android-image-view-source-array-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Android] Add headers support when passing source array #32863
marcesengel
wants to merge
8
commits into
facebook:main
from
marcesengel:android-image-view-source-array-headers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified code flow Removed native headers prop in favour of passing them in the src array
Hopefully this is not irritating for them - but I requested review from @mdvacca and @yungsters - they appear to be the most recent editors in this area? Apologies in advance if that's a courtesy breach. Cheers all |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Not stale 😖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Never gets stale
Prevent those issues and PRs from getting stale
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently passing headers in the
source
array of an<ImageView />
is not supported on android becauseReadableMap
prop, passed as-is to theReactNetworkImageRequest.fromBuilderWithHeaders
. This means different headers per array entry are simply not possiblesource?.headers
which clearly will not work when putting the headers into the source array (e.g.[ { headers: { Test: '123' }, uri: '...' } ]
- this also showcases a workaround, just set theheaders
property on your source array and you are good to go as long as you always need the same headers)Changelog
<Image />
code flowheaders
property into thesrc
propertyheaders
property toImageSource
class[Android] [Fix] - Support headers when passing an array for the
<Image />
source
propertyTest Plan
CI tests should cover these changes.
Edit: Also confirmed working in a test project.