Use compose to render Switch in Fabric #32871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change is a proof of concept to try Compose integration with RN component on Android by measuring and drawing Switch component through a Composable function. To interface Composable nodes with the view system, we use a "classic" view interoperability layer to plug Compose-based Switch into existing ViewManager and propagate props and events as we do with “classic” views. Fabric also requires initial measure during layout, which was implemented through custom background `Recomposer` and `LayoutNode` hacks to avoid creating full-blown view. Differential Revision: D31657259 fbshipit-source-id: ad5d2434d8c783d03f93b829e46e7e09ef5c4564
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D31657259 |
|
For reference: screencap + Flipper layout view
|
|
Base commit: 0fccbd5 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
cortinico
removed
the
Stale
cortinico
added
the
Never gets stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change is a proof of concept to try Compose integration with RN component on Android by measuring and drawing Switch component through a Composable function.
To interface Composable nodes with the view system, we use a "classic" view interoperability layer to plug Compose-based Switch into existing ViewManager and propagate props and events as we do with “classic” views.
Fabric also requires initial measure during layout, which was implemented through custom background
RecomposerandLayoutNodehacks to avoid creating full-blown view.Differential Revision: D31657259