Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new iOS text content type cellular EID and cellular IMEI (#46378) #46507

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
Support for new iOS text content type to autofill cellular EID or cellular IMEI:

Changelog:

[General][Added] - Add JS layer for new text content type cellular EID and cellular IMEI

Test Plan:
JavaScript Tests - yarn test [PASSED]

  • No errors related with the changes

Flow - yarn flow && yarn lint [PASSED]

  • No errors related with the changes

iOS Tests - ./scripts/objc-test.sh test [PASSED]

  • No errors related with the changes

Build RNTester [PASSED]

  • No errors related with the changes
  • Proof:
Screenshot 2024-09-07 at 12 06 48 Screenshot 2024-09-07 at 12 07 29 Screenshot 2024-09-07 at 12 13 02

Simulator Screenshot - iPhone 15 Pro - 2024-09-07 at 12 06 36
Note: Since the test was done using an iOS simulator the autofill suggestion won't appear for the cellularEID or cellularIMEI

Reviewed By: cortinico

Differential Revision: D62737200

Pulled By: cipolleschi

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62737200

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62737200

…MEI (facebook#46507)

Summary:

Support for new iOS text content type to autofill cellular EID or cellular IMEI:
- https://developer.apple.com/documentation/uikit/uitextcontenttypecellulareid?language=objc
- https://developer.apple.com/documentation/uikit/uitextcontenttypecellularimei?language=objc

## Changelog:

[General][Added] - Add JS layer for new text content type cellular EID and cellular IMEI

Reviewed By: cortinico

Differential Revision: D62737200
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62737200

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 118c1f7.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 118c1f7

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants