Add unstable ReferenceStateWrapper API
#50921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We construct this from JNI, which doesn't care about visibility, and then only want to expose `StateWrapper` as the public interface. Changelog: [Android][Removed] - Make StateWrapperImpl Internal Reviewed By: Abbondanzo Differential Revision: D73161592
Summary: This adds the ability to represent Fabric State sent to Java View managers as a raw JNI reference. This is used by Facsimile to tell a component to mount a layout, previously generated during measurement. This API is consciously well hidden (in comparison to MapBuffer which is fairly public). To use it: 1. The concrete state data representation must implement a method named `getJNIReference()` that returns an fbjni ref 2. The Java view manager must cast the `StateWrapper` to an internal `ReferenceStateWrapper` type, not exposed outside of React Native internals Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D73159146
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73159146 |
|
This pull request has been merged in 75a01c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds the ability to represent Fabric State sent to Java View managers as a raw JNI reference. This is used by Facsimile to tell a component to mount a layout, previously generated during measurement.
This API is consciously well hidden (in comparison to MapBuffer which is fairly public). To use it:
getJNIReference()that returns an fbjni refStateWrapperto an internalReferenceStateWrappertype, not exposed outside of React Native internalsChangelog: [Internal]
Reviewed By: alanleedev
Differential Revision: D73159146