JSX Fantom benchmark #54336
Closed
JSX Fantom benchmark #54336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: facebook#54336 # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
038f63e to
f3d1910
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: facebook#54336 # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
f3d1910 to
68dfed4
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: facebook#54336 # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
68dfed4 to
970b317
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 31, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 31, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 31, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
970b317 to
82270d1
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Oct 31, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
2 times, most recently
from
5ccc014 to
c50bd23
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 3, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 3, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 3, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 3, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
c50bd23 to
10059bf
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 5, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 5, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 5, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 5, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Nov 5, 2025
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
10059bf to
b4905ea
Compare
Summary: # Changelog: [Internal] This is not used, nor required. The controller is the canonical way of using targets. Reviewed By: huntie Differential Revision: D85440639
…k#54282) Summary: # Changelog: [Internal] It is already in a tracing session state, we are going to use it in RuntimeTarget. Reviewed By: huntie Differential Revision: D85440638
Summary: # Changelog: [Internal] This will control scenarios when we enable `console.createTask` implementation, and when we just use the stub version. Reviewed By: huntie Differential Revision: D85440641
Summary: # Changelog: [Internal] This defines the main entities for the console.createTask(): - ConsoleTaskOrchestrator: global stack that can be used as a source of pending tasks. - ConsoleTaskContext: RAII object, captures the context for a specific task. Lifetime is bound to the lifetime of the task object in JavaScript. - ConsoleTask: RAII-like object. Initialized only during the callback run of `task.run(...)`. I couldn't find a better way to solve this without having a static singleton. Native modules don't have access to ReactInstance object, so we won't be able to access this global stack from `performance.measure` implementation, for example. Not using the word `async` anywhere in the naming, because the current implementation doesn't support async stack traces. Reviewed By: sbuggay Differential Revision: D85481864
Summary: # Changelog: [Internal] Adds a basic implementation of the `console.createTask()` method. When this method is called, the `ConsoleTaskContext` is allocated. When `task.run()` is called, the corresponding `ConsoleTask` that has a pointer to `ConsoleTaskContext` will push it onto the stack in `ConsoleTaskOrchestrator`. Also adds types to corresponding Flow declarations. Reviewed By: sbuggay Differential Revision: D85481865
Summary: # Changelog: [Internal] I couldn't add it to the previous diff, since console.createTask is not present on the base revision. See [1]. Reviewed By: sbuggay Differential Revision: D85860982
Summary: # Changelog: [Internal] Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger. Since this only happens in DEV, I have to force dev mode in Fantom as well. Reviewed By: sbuggay Differential Revision: D85860981
hoxyq
force-pushed
the
export-D85860981
branch
from
b4905ea to
742a31d
Compare
|
This pull request has been merged in 21c211d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds a benchmark that is scoped to JSX scenario. React uses createTask() on JSX instances to preserve owner stacks relationship, and so users can see tree-like stacks in the debugger.
Since this only happens in DEV, I have to force dev mode in Fantom as well.
Differential Revision: D85860981