Skip to content

Conversation

@hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Nov 3, 2025

Summary:

Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Differential Revision: D85996394

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 3, 2025

@hoxyq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85996394.

hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 6, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 6, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 6, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 6, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 7, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 7, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added 4 commits November 7, 2025 03:44
Summary:

# Changelog: [Internal]

Defines tracing category as a concept.

The end goal is to be able to control these categories from the frontend, so that we only enable what user has requested.

Reviewed By: sbuggay

Differential Revision: D85912264
Summary:

# Changelog: [Internal]

According to the only public document that we have about Trace Event format, a single Trace Event could have multiple categories.

However, we don't have yet a single instance of this, that's why I am using `folly:small_vector<..., 1>` to optimize for such case.

Reviewed By: sbuggay

Differential Revision: D85973670
Summary:

# Changelog: [Internal]

The CDP protocol concatenates categories in a single string, joined with comma.

In this diff, we introduce a method that will parse such string and return a set of local categories.

Reviewed By: sbuggay

Differential Revision: D85996396
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
hoxyq added a commit to hoxyq/react-native that referenced this pull request Nov 7, 2025
Summary:

# Changelog: [Internal]

We can now propagate down enabled categories to the state of trace recording.

Reviewed By: huntie

Differential Revision: D85996394
@meta-codesync meta-codesync bot closed this in 3841ef0 Nov 7, 2025
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 7, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 7, 2025

This pull request has been merged in 3841ef0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants