Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] InferReferenceEffects outputs a disjoint set of aliases #30974

Open
wants to merge 5 commits into
base: gh/mvitousek/35/base
Choose a base branch
from
Open

[compiler] InferReferenceEffects outputs a disjoint set of aliases #30974

wants to merge 5 commits into from
+120 −3

Commits on Sep 16, 2024

  1. [compiler] InferReferenceEffects outputs a disjoint set of aliases 

    Test Plan:
For the purposes of a pass added later in this stack, the InferReferenceEffects now outputs a DisjointSet of identifier ids representing aliases. We add this to InferReferenceEffects because this pass already does its own alias analysis, so making it available to later passes is convenient.

This entails implementing copy() and equals() methods on DIsjointSets so that the InferenceState copy and merge methods can handle alias sets.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    10d8b63 View commit details
    Browse the repository at this point in the history

  2. Update on "[compiler] InferReferenceEffects outputs a disjoint set of… 

    … aliases"

Test Plan:
For the purposes of a pass added later in this stack, the InferReferenceEffects now outputs a DisjointSet of identifier ids representing aliases. We add this to InferReferenceEffects because this pass already does its own alias analysis, so making it available to later passes is convenient.

This entails implementing copy() and equals() methods on DIsjointSets so that the InferenceState copy and merge methods can handle alias sets.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9bccf67 View commit details
    Browse the repository at this point in the history

  3. Update on "[compiler] InferReferenceEffects outputs a disjoint set of… 

    … aliases"

Test Plan:
For the purposes of a pass added later in this stack, the InferReferenceEffects now outputs a DisjointSet of identifier ids representing aliases. We add this to InferReferenceEffects because this pass already does its own alias analysis, so making it available to later passes is convenient.

This entails implementing copy() and equals() methods on DIsjointSets so that the InferenceState copy and merge methods can handle alias sets.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b12a80a View commit details
    Browse the repository at this point in the history

  4. Update on "[compiler] InferReferenceEffects outputs a disjoint set of… 

    … aliases"

Test Plan:
For the purposes of a pass added later in this stack, the InferReferenceEffects now outputs a DisjointSet of identifier ids representing aliases. We add this to InferReferenceEffects because this pass already does its own alias analysis, so making it available to later passes is convenient.

This entails implementing copy() and equals() methods on DIsjointSets so that the InferenceState copy and merge methods can handle alias sets.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4c5c82f View commit details
    Browse the repository at this point in the history

  5. Update on "[compiler] InferReferenceEffects outputs a disjoint set of… 

    … aliases"

Test Plan:
For the purposes of a pass added later in this stack, the InferReferenceEffects now outputs a DisjointSet of identifier ids representing aliases. We add this to InferReferenceEffects because this pass already does its own alias analysis, so making it available to later passes is convenient.

This entails implementing copy() and equals() methods on DIsjointSets so that the InferenceState copy and merge methods can handle alias sets.

[ghstack-poisoned]
    @mvitousek
    mvitousek committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0fd2cc2 View commit details
    Browse the repository at this point in the history