-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new defineConsts
api
#944
Open
mellyeliu
wants to merge
3
commits into
main
Choose a base branch
from
feat/define-consts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57562b0
to
a114310
Compare
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
a114310
to
4135c51
Compare
4135c51
to
75dcd1b
Compare
75dcd1b
to
991bccf
Compare
991bccf
to
b79011c
Compare
b79011c
to
eeef0ca
Compare
eeef0ca
to
25fe765
Compare
25fe765
to
851cfed
Compare
851cfed
to
0746071
Compare
0746071
to
c352d3c
Compare
defineConsts
apidefineConsts
api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds support for new API
stylex.defineConsts
to inject constants into the css transform pipeline and replacevar(--token)
usage with raw values when processing rulesshared
{ constKey, constVal }
key
to match css variable formatdefineConsts babel transform
stylex.defineConsts
stylexDefineConsts
to convert obj to js output and metadataconst colors = { red: '#ff0000' }
state.registerStyles
using the hash and{ constKey, constVal }
to be used in rules processingprocessStylexRules
constKey
andconstVal
from any rules that came fromdefineConsts
store them in dict from
var(--hash)
to valuerules
, replace:var(--hash)
to raw valuevar(--hash, fallback)
to raw value (to do in follow up with TokenParser)this is done for both
ltr
andrtl
if presentTesting
Added transform and shared utils tests
Tested E2E in examples

Pre-flight checklist
Contribution Guidelines