Skip to content

Conversation

tyroguru
Copy link
Collaborator

@tyroguru tyroguru commented Jul 26, 2023

Summary

WIP draft.

Test plan

Check that OI is working correctly, you can add some unit or integration test,
paste the output of some manual test, and / or paste the output of running
the test locally with make test-static

@tyroguru tyroguru changed the title ptraces fixes ptrace related fixes Jul 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #270 (02ec288) into main (b834c92) will decrease coverage by 0.43%.
Report is 17 commits behind head on main.
The diff coverage is 14.65%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   66.99%   66.57%   -0.43%     
==========================================
  Files          99       99              
  Lines       10321    10393      +72     
  Branches     1709     1724      +15     
==========================================
+ Hits         6915     6919       +4     
- Misses       2523     2587      +64     
- Partials      883      887       +4     
Files Changed Coverage Δ
oi/OIDebugger.h 45.28% <ø> (ø)
oi/OIDebugger.cpp 37.51% <14.65%> (-1.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@facebook-github-bot
Copy link

Hi @tyroguru!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants